Merge lp:~vorlon/console-setup/missing-systemd-units into lp:~ubuntu-core-dev/console-setup/ubuntu

Proposed by Steve Langasek
Status: Needs review
Proposed branch: lp:~vorlon/console-setup/missing-systemd-units
Merge into: lp:~ubuntu-core-dev/console-setup/ubuntu
Diff against target: 45 lines (+28/-0)
3 files modified
debian/changelog (+7/-0)
debian/console-setup-linux.setvtrgb.service (+8/-0)
debian/console-setup.console-font.service (+13/-0)
To merge this branch: bzr merge lp:~vorlon/console-setup/missing-systemd-units
Reviewer Review Type Date Requested Status
Martin Pitt Needs Fixing
Review via email: mp+254965@code.launchpad.net

Description of the change

http://people.canonical.com/~jhunt/systemd/packages-to-convert/ still shows two upstart jobs in console-setup without corresponding systemd units. I don't see anything in systemd that would handle these pieces of the setup, so believe we still need to add units such as the ones in this MP.

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

Thanks Steve! Comments inline. I think this needs fixing, but I didn't check the existing package (in a train/holidays).

review: Needs Fixing

Unmerged revisions

453. By Steve Langasek

Add corresponding systemd units for the console-setup, console-setup-linux
packages.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2015-04-01 17:52:12 +0000
3+++ debian/changelog 2015-04-01 18:25:50 +0000
4@@ -1,3 +1,10 @@
5+console-setup (1.108ubuntu5) UNRELEASED; urgency=medium
6+
7+ * Add corresponding systemd units for the console-setup, console-setup-linux
8+ packages.
9+
10+ -- Steve Langasek <steve.langasek@ubuntu.com> Wed, 01 Apr 2015 11:09:49 -0700
11+
12 console-setup (1.108ubuntu4) vivid; urgency=medium
13
14 * Add systemd unit for console-setup. That avoids waiting for $remote_fs
15
16=== added file 'debian/console-setup-linux.setvtrgb.service'
17--- debian/console-setup-linux.setvtrgb.service 1970-01-01 00:00:00 +0000
18+++ debian/console-setup-linux.setvtrgb.service 2015-04-01 18:25:50 +0000
19@@ -0,0 +1,8 @@
20+# This job configures the virtual terminal console colors
21+[Unit]
22+Description=set virtual terminal colors
23+After=getty@tty1.service plymouth-start.service
24+
25+[Service]
26+Type=oneshot
27+ExecStart=/sbin/setvtrgb /etc/vtrgb
28
29=== added file 'debian/console-setup.console-font.service'
30--- debian/console-setup.console-font.service 1970-01-01 00:00:00 +0000
31+++ debian/console-setup.console-font.service 2015-04-01 18:25:50 +0000
32@@ -0,0 +1,13 @@
33+# Set the console font, in case the similar udev rule races with Plymouth
34+# and thus fails to do it.
35+[Unit]
36+Description=Set console font
37+DefaultDependencies=no
38+Before=plymouth-start.service
39+
40+[Service]
41+Type=oneshot
42+ExecStart=/lib/udev/console-setup-tty fbcon
43+
44+[Install]
45+RequiredBy=plymouth-start.service

Subscribers

People subscribed via source and target branches

to all changes: