Created by Steve Langasek on 2013-04-07 and last modified on 2013-04-07
Get this branch:
bzr branch lp:~vorlon/compiz/lp.763148
Only Steve Langasek can upload to this branch. If you are Steve Langasek please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Steve Langasek

Recent revisions

3651. By Steve Langasek on 2013-04-07

further reduce repetition in the test code, per Sam's feedback

3650. By Steve Langasek on 2013-04-07

plugins/place/src/place.cpp: in some cases, we see configure events sent
for the root window twice in a row before all windows have had a chance
to handle the first, which corrupts the old state. So ignore root
configure events that don't change the size.

3649. By Steve Langasek on 2013-04-07

Make sure windows remain on the same viewport they started out on when
the screen resolution changes. LP: #763148.

3648. By Steve Langasek on 2013-04-07

Add more tests for window placement on resizing

3647. By Steve Langasek on 2013-04-07

Drop the 'curVpOffsetX/Y' obfuscation, which is only ever used in equations
where it cancels out!

3646. By Steve Langasek on 2013-04-07

Refactor test case to make the code more readable; split into multiple tests
for better legibility in the case of test failures; lays the groundwork for
added tests for bug #763148.

3645. By Gabriel Ebner on 2013-04-03

Adding a uniform to a GLVertexBuffer that uses AutoProgram causes compiz to segfault.

  gWindow->addShaders("cms", "", fragment_shader);
  gWindow->vertexBuffer()->addUniform("cms_lut", unit);
  // segfault happens later in PrivateVertexBuffer::render

The patch modifies PrivateVertexBuffer::render to set the uniform on the generated AutoProgram instead of the provided program, which in this case is NULL, causing a segfault.

(LP: #1162598). Fixes: https://bugs.launchpad.net/bugs/1162598.

Approved by PS Jenkins bot, Sam Spilsbury.

3644. By MC Return on 2013-04-03

Hopefully fixed all memory leaks in libcompizconfig.
Minor whitespace fixes.

(LP: #1076297). Fixes: https://bugs.launchpad.net/bugs/1076297.

Approved by PS Jenkins bot, Sam Spilsbury.

3643. By MC Return on 2013-03-30


Damage the text area correctly.
Extract the method used to determine where the text area was
into a separate function and use that to determine where our
damage area should be.
Also fix a few errors that happened on the last frame of animation.

This also fixes the flickering during display.

Other minor code refactoring.

(LP: #1075578, LP: #1162246). Fixes: https://bugs.launchpad.net/bugs/1075578, https://bugs.launchpad.net/bugs/1162246.

Approved by PS Jenkins bot, Sam Spilsbury.

3642. By MC Return on 2013-03-30

Show Desktop Upgrade:

Renamed "Show desktop" to "Show Desktop" (uppercase).

New features:

* Added individual movement options for all 4 corners.

* Implemented the new movement direction option "Intelligent Random".
  This option will make windows slide out of view in one of 3
  random directions (Top/Bottom / Left/Right / ToCorners) using the
  shortest movement distance, when Show Desktop is invoked.

* Also implemented a "Fully Random" movement direction mode, which will
  move every window out of view using one of 8 randomly chosen directions
  (one of 4 corners or one of 4 edges of the virtual screen).

enum IRDirection represents allowed directions in Intelligent Random
Direction mode, while enum FRDirection represents allowed directions
in Fully Random Direction mode.

Refactored ShowdesktopPlacer:
1. Removed #define macros and replaced them with inline functions in ::.
2. Refactored out the offset algorithms into separate functions.
3. Placed the actual offset + setting algorithms into ShowdesktopPlacer
and re-used where appropriate. This reduces the size of

Simplified void ShowdesktopScreen::donePaint () and removed redundant
damageScreen () call.

Removal of redundant brackets, declaration and assignment of variables in
the same line, indentation fixes, readability improvements and general

(LP: #1161343). Fixes: https://bugs.launchpad.net/bugs/1161343.

Approved by PS Jenkins bot, MC Return.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
This branch contains Public information 
Everyone can see this information.