Merge ~vorlon/cloud-init:lp.1134036 into cloud-init:master
Status: | Work in progress |
---|---|
Proposed branch: | ~vorlon/cloud-init:lp.1134036 |
Merge into: | cloud-init:master |
Diff against target: |
133 lines (+32/-66) 1 file modified
tools/Z99-cloud-locale-test.sh (+32/-66) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Scott Moser | Needs Information | ||
Server Team CI bot | continuous-integration | Approve | |
Review via email: mp+348101@code.launchpad.net |
Commit message
Fix up invalid locales in the login environment; don't print warning messages.
Invalid locales in the environment at login (e.g. as provided by ssh
SendEnv from a client system which has a different set of available locales
than the server) currently result in a large warning message (once, per
login user, per instance) and a broken environment.
On Ubuntu systems, and probably others, this broken environment results in
wrong runtime behavior vs if no locale had been passed at all by the client;
in particular, Ubuntu systems will give UTF-8 as a character set by default
(either the en_US.UTF-8 or C.UTF-8 locale, depending on the version of
Ubuntu), and if an invalid locale is specified, the login instead will use
ASCII as the only supported character set.
This change reworks cloud-init's profile handling to:
- fix up any invalid locale settings detected in the environment, so that
the login session does not unnecessarily lose non-ascii character support
due to a requested missing locale
- remove the warning message, which is of disputed value.
This approximates the OpenSSH upstream guidance regarding a correct design
for this in OpenSSH itself, as described at
<https:/
all systems which do not have an ssh client+server that implement that does
not implement this proposed design (i.e.: all clients and servers currently
in existence).
LP: #1134036
FAILED: Continuous integration, rev:70743abe09a 3f20d4c20995ea7 45fff49edf3edc /code.launchpad .net/~vorlon/ cloud-init/ +git/cloud- init/+merge/ 348101/ +edit-commit- message
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
https:/ /jenkins. ubuntu. com/server/ job/cloud- init-ci/ 97/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu LTS: Integration
SUCCESS: MAAS Compatability Testing
IN_PROGRESS: Declarative: Post Actions
Click here to trigger a rebuild: /jenkins. ubuntu. com/server/ job/cloud- init-ci/ 97/rebuild
https:/