Terminal

Merge lp:~voldyman/pantheon-terminal/space-at-end into lp:~elementary-apps/pantheon-terminal/trunk

  1. space-at-end
  2. Merge into trunk
Proposed by Akshay Shekher
Status: Merged
Merged at revision: 421
Proposed branch: lp:~voldyman/pantheon-terminal/space-at-end
Merge into: lp:~elementary-apps/pantheon-terminal/trunk
Diff against target: 18 lines (+2/-2)
1 file modified
src/TerminalWidget.vala (+2/-2)
To merge this branch: bzr merge lp:~voldyman/pantheon-terminal/space-at-end
Reviewer Review Type Date Requested Status
David Gomes (community) Approve
Review via email: mp+141615@code.launchpad.net
To post a comment you must log in.
Revision history for this message
David Gomes (davidgomes) wrote :

Good code.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'po/fa.po' (properties changed: -x to +x)
2=== modified file 'src/TerminalWidget.vala'
3--- src/TerminalWidget.vala 2012-12-27 09:36:29 +0000
4+++ src/TerminalWidget.vala 2013-01-02 14:30:30 +0000
5@@ -301,11 +301,11 @@
6 for (var i = 0; i < uris.length; i++) {
7 file = File.new_for_uri (uris[i]);
8 if ((path = file.get_path ()) != null) {
9- uris[i] = Shell.quote (path);
10+ uris[i] = Shell.quote (path) + " ";
11 }
12 }
13
14- string uris_s = string.joinv (" ", uris);
15+ string uris_s = string.joinv ("", uris);
16 this.feed_child (uris_s, uris_s.length);
17 }
18 }

Subscribers

People subscribed via source and target branches