Merge lp:~voldyman/pantheon-terminal/fixed-1016282 into lp:~elementary-apps/pantheon-terminal/trunk

Proposed by Akshay Shekher
Status: Merged
Merged at revision: 250
Proposed branch: lp:~voldyman/pantheon-terminal/fixed-1016282
Merge into: lp:~elementary-apps/pantheon-terminal/trunk
Diff against target: 226 lines (+77/-53)
2 files modified
po/pantheon-terminal.pot (+58/-44)
src/ForegroundProcessDialog.vala (+19/-9)
To merge this branch: bzr merge lp:~voldyman/pantheon-terminal/fixed-1016282
Reviewer Review Type Date Requested Status
Cody Garver (community) Approve
Review via email: mp+116126@code.launchpad.net

Description of the change

Fixed Foreground Process Dialog UI.

To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'po/pantheon-terminal.pot'
2--- po/pantheon-terminal.pot 2012-06-05 16:11:28 +0000
3+++ po/pantheon-terminal.pot 2012-07-21 19:00:28 +0000
4@@ -8,7 +8,7 @@
5 msgstr ""
6 "Project-Id-Version: PACKAGE VERSION\n"
7 "Report-Msgid-Bugs-To: \n"
8-"POT-Creation-Date: 2012-06-05 09:09-0700\n"
9+"POT-Creation-Date: 2012-07-22 00:27+0530\n"
10 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
11 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
12 "Language-Team: LANGUAGE <LL@li.org>\n"
13@@ -17,102 +17,116 @@
14 "Content-Type: text/plain; charset=CHARSET\n"
15 "Content-Transfer-Encoding: 8bit\n"
16
17-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/PantheonTerminal.vala:87
18+#: /home/akshay/Desktop/pantheon-terminal/po/../src/PantheonTerminal.vala:87
19 msgid "Set shell at launch"
20 msgstr ""
21
22-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/PantheonTerminalWindow.vala:78
23-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/PantheonTerminalWindow.vala:212
24+#: /home/akshay/Desktop/pantheon-terminal/po/../src/ForegroundProcessDialog.vala:29
25+msgid "Are you sure you want to close this tab?"
26+msgstr ""
27+
28+#: /home/akshay/Desktop/pantheon-terminal/po/../src/ForegroundProcessDialog.vala:30
29+msgid "There is an active process on this tab."
30+msgstr ""
31+
32+#: /home/akshay/Desktop/pantheon-terminal/po/../src/ForegroundProcessDialog.vala:31
33+msgid "If you close this tab, this process will end."
34+msgstr ""
35+
36+#: /home/akshay/Desktop/pantheon-terminal/po/../src/ForegroundProcessDialog.vala:33
37+#: /home/akshay/Desktop/pantheon-terminal/po/../src/ForegroundProcessDialog.vala:52
38+msgid "Cancel"
39+msgstr ""
40+
41+#: /home/akshay/Desktop/pantheon-terminal/po/../src/ForegroundProcessDialog.vala:37
42+msgid "Close Tab"
43+msgstr ""
44+
45+#: /home/akshay/Desktop/pantheon-terminal/po/../src/ForegroundProcessDialog.vala:48
46+msgid "Are you sure you want to quit Terminal?"
47+msgstr ""
48+
49+#: /home/akshay/Desktop/pantheon-terminal/po/../src/ForegroundProcessDialog.vala:49
50+msgid "There is an active process on this terminal."
51+msgstr ""
52+
53+#: /home/akshay/Desktop/pantheon-terminal/po/../src/ForegroundProcessDialog.vala:50
54+msgid "If you quit Terminal, this process will end."
55+msgstr ""
56+
57+#: /home/akshay/Desktop/pantheon-terminal/po/../src/ForegroundProcessDialog.vala:56
58+msgid "Quit Terminal"
59+msgstr ""
60+
61+#: /home/akshay/Desktop/pantheon-terminal/po/../src/PantheonTerminalWindow.vala:78
62+#: /home/akshay/Desktop/pantheon-terminal/po/../src/PantheonTerminalWindow.vala:232
63 msgid "Terminal"
64 msgstr ""
65
66-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/PantheonTerminalWindow.vala:127
67+#: /home/akshay/Desktop/pantheon-terminal/po/../src/PantheonTerminalWindow.vala:127
68 msgid "Open a new tab"
69 msgstr ""
70
71-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/PantheonTerminalWindow.vala:350
72+#: /home/akshay/Desktop/pantheon-terminal/po/../src/PantheonTerminalWindow.vala:381
73 msgid "Quit"
74 msgstr ""
75
76-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/PantheonTerminalWindow.vala:351
77+#: /home/akshay/Desktop/pantheon-terminal/po/../src/PantheonTerminalWindow.vala:382
78 msgid "Close"
79 msgstr ""
80
81-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/PantheonTerminalWindow.vala:352
82+#: /home/akshay/Desktop/pantheon-terminal/po/../src/PantheonTerminalWindow.vala:383
83 msgid "New Window"
84 msgstr ""
85
86-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/PantheonTerminalWindow.vala:352
87+#: /home/akshay/Desktop/pantheon-terminal/po/../src/PantheonTerminalWindow.vala:383
88 msgid "Open a new window"
89 msgstr ""
90
91-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/PantheonTerminalWindow.vala:354
92+#: /home/akshay/Desktop/pantheon-terminal/po/../src/PantheonTerminalWindow.vala:385
93 msgid "New Tab"
94 msgstr ""
95
96-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/PantheonTerminalWindow.vala:354
97+#: /home/akshay/Desktop/pantheon-terminal/po/../src/PantheonTerminalWindow.vala:385
98 msgid "Create a new tab"
99 msgstr ""
100
101-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/PantheonTerminalWindow.vala:355
102+#: /home/akshay/Desktop/pantheon-terminal/po/../src/PantheonTerminalWindow.vala:386
103 msgid "Copy"
104 msgstr ""
105
106-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/PantheonTerminalWindow.vala:355
107+#: /home/akshay/Desktop/pantheon-terminal/po/../src/PantheonTerminalWindow.vala:386
108 msgid "Copy the selected text"
109 msgstr ""
110
111-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/PantheonTerminalWindow.vala:356
112+#: /home/akshay/Desktop/pantheon-terminal/po/../src/PantheonTerminalWindow.vala:387
113 msgid "Paste"
114 msgstr ""
115
116-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/PantheonTerminalWindow.vala:356
117+#: /home/akshay/Desktop/pantheon-terminal/po/../src/PantheonTerminalWindow.vala:387
118 msgid "Paste some text"
119 msgstr ""
120
121-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/PantheonTerminalWindow.vala:357
122+#: /home/akshay/Desktop/pantheon-terminal/po/../src/PantheonTerminalWindow.vala:388
123 msgid "Select All"
124 msgstr ""
125
126-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/PantheonTerminalWindow.vala:358
127+#: /home/akshay/Desktop/pantheon-terminal/po/../src/PantheonTerminalWindow.vala:389
128 msgid "Select all the text in the terminal"
129 msgstr ""
130
131-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/PantheonTerminalWindow.vala:359
132+#: /home/akshay/Desktop/pantheon-terminal/po/../src/PantheonTerminalWindow.vala:390
133 msgid "About"
134 msgstr ""
135
136-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/PantheonTerminalWindow.vala:359
137+#: /home/akshay/Desktop/pantheon-terminal/po/../src/PantheonTerminalWindow.vala:390
138 msgid "Show about window"
139 msgstr ""
140
141-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/PantheonTerminalWindow.vala:361
142+#: /home/akshay/Desktop/pantheon-terminal/po/../src/PantheonTerminalWindow.vala:392
143 msgid "Fullscreen"
144 msgstr ""
145
146-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/PantheonTerminalWindow.vala:361
147+#: /home/akshay/Desktop/pantheon-terminal/po/../src/PantheonTerminalWindow.vala:392
148 msgid "Toggle/Untoggle fullscreen"
149 msgstr ""
150-
151-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/ForegroundProcessDialog.vala:29
152-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/ForegroundProcessDialog.vala:43
153-msgid "There is an active process on this terminal!"
154-msgstr ""
155-
156-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/ForegroundProcessDialog.vala:30
157-msgid "Do you want to stay on the terminal?"
158-msgstr ""
159-
160-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/ForegroundProcessDialog.vala:32
161-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/ForegroundProcessDialog.vala:46
162-msgid "Stay"
163-msgstr ""
164-
165-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/ForegroundProcessDialog.vala:36
166-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/ForegroundProcessDialog.vala:50
167-msgid "Close terminal"
168-msgstr ""
169-
170-#: /home/ttosttos/Projects/elementary/Bugs/pantheon-terminal-fix-989076/po/../src/ForegroundProcessDialog.vala:44
171-msgid "Do you want to close this terminal?"
172-msgstr ""
173
174=== modified file 'src/ForegroundProcessDialog.vala'
175--- src/ForegroundProcessDialog.vala 2012-05-14 20:46:00 +0000
176+++ src/ForegroundProcessDialog.vala 2012-07-21 19:00:28 +0000
177@@ -26,30 +26,40 @@
178
179 public ForegroundProcessDialog () {
180 use_markup = true;
181- set_markup ("<b>" + _("There is an active process on this terminal!") + "</b>\n\n" +
182- _("Do you want to stay on the terminal?"));
183+ set_markup ("<b>" + _("Are you sure you want to close this tab?") + "</b>\n\n" +
184+ _("There is an active process on this tab.")+"\n"+
185+ _("If you close this tab, this process will end."));
186
187- var button = new Gtk.Button.with_label (_("Stay"));
188+ var button = new Gtk.Button.with_label (_("Cancel"));
189 button.show ();
190 add_action_widget (button, 0);
191
192- button = new Gtk.Button.with_label (_("Close terminal"));
193+ button = new Gtk.Button.with_label (_("Close Tab"));
194 button.show ();
195 add_action_widget (button, 1);
196+
197+ var warning_image = new Gtk.Image.from_stock (Gtk.Stock.DIALOG_WARNING, Gtk.IconSize.DIALOG);
198+ set_image (warning_image);
199+ warning_image.show ();
200 }
201
202 public ForegroundProcessDialog.before_close () {
203 use_markup = true;
204- set_markup ("<b>" + _("There is an active process on this terminal!") + "</b>\n\n" +
205- _("Do you want to close this terminal?"));
206-
207- var button = new Gtk.Button.with_label (_("Stay"));
208+ set_markup ("<b>" + _("Are you sure you want to quit Terminal?") + "</b>\n\n" +
209+ _("There is an active process on this terminal.")+"\n"+
210+ _("If you quit Terminal, this process will end."));
211+
212+ var button = new Gtk.Button.with_label (_("Cancel"));
213 button.show ();
214 add_action_widget (button, 0);
215
216- button = new Gtk.Button.with_label (_("Close terminal"));
217+ button = new Gtk.Button.with_label (_("Quit Terminal"));
218 button.show ();
219 add_action_widget (button, 1);
220+
221+ var warning_image = new Gtk.Image.from_stock (Gtk.Stock.DIALOG_WARNING, Gtk.IconSize.DIALOG);
222+ set_image (warning_image);
223+ warning_image.show ();
224 }
225 }
226 }

Subscribers

People subscribed via source and target branches