Merge lp:~voldyman/indicator-network/onlyshowin-add-pantheon into lp:indicator-network/14.10

[Akshay Shekher]

Added Pantheon in the onlyshowin list.

[Ted Gould (ted)]

I don't think this is what you want. On the desktop we're still using nm-applet with indicator-application, indicator-network only covers the phone use-cases today. I'm happy with the patch generally though.

review: Needs Information

[Akshay Shekher (voldyman)]

Yup I know about that, and I'd like to be able to use this indicator too.

[Ted Gould (ted)]

Okay.

review: Approve

[Carlin Mangar (openshift)]

Unfortunately, you cannot install indicator-network without pulling in the whole Unity8 package.

[Matthew Paul Thomas (mpt)]

Carlin, I've reported that inappropriate dependency as bug 1318533.

[Antti Kaijanmäki (kaijanmaki)]

please, see my comments in bug #1318533.

Given the situation even the "GNOME" should be removed from OnlyShowIn. (And I will remove it.)

For now I'm going to reject this patch until Pantheon has appropriate indicator and notification services.

review: Disapprove

Unmerged revisions

328. By Akshay Shekher on 2014-04-13

Added Pantheon to OnlyShowIn list in the .desktop file

=== modified file 'data/indicator-network.desktop.in'
--- data/indicator-network.desktop.in	2014-02-26 16:37:56 +0000
+++ data/indicator-network.desktop.in	2014-04-13 11:04:21 +0000
@@ -4,5 +4,5 @@
 Exec=@NETWORK_SERVICE@
 StartupNotify=false
 Terminal=false
-OnlyShowIn=Unity;GNOME;
+OnlyShowIn=Unity;GNOME;Pantheon;
 AutostartCondition=GNOME3 unless-session gnome