Merge lp:~voldyman/granite/fixed-960531 into lp:~elementary-pantheon/granite/granite

[Akshay Shekher]

in the about dialog box. when the user clicks "Report A Problem"
"ubuntu-bug `pidOfCurrentProcess`"

[Sergey "Shnatsel" Davidoff (shnatsel)]

Cool, I didn't know ubuntu-bug can be called by PID. I don't like the fact that activate_link(bug) is commented out; it should be called from the exception handler if launching ubuntu-bug fails, for compatibility with distros other than Ubuntu.

[Akshay Shekher (voldyman)]

i was thinking if apport-gui might be a better option than ubuntu-bug.
what your opinion.

[Sergey "Shnatsel" Davidoff (shnatsel)]

Turns out "apport-bug" is the real executable name, "ubuntu-bug" is just an alias. There's no "apport-gui" command.

[lp:~voldyman/granite/fixed-960531]

303. By Akshay Shekher on 2012-07-12

Moved activate_link to exception handler

304. By Akshay Shekher on 2012-07-12

Using apport-bug instead of ubuntu-bug

305. By Akshay Shekher on 2012-07-12

this one is for ricotz. fixed spacing and int cast

306. By Akshay Shekher on 2012-07-12

fixed 'minor' error.ricotz 2 voldyman 0.

[Akshay Shekher (voldyman)]

after a lot of discussion on how to support(or not) apport-bug on distributions other than ubuntu. this has been finalized.

try { [run apport-bug] }
catch { [open link to lauchpad bug report] }

 <voldyman> shnatsel, has anything been decided for apport ??
 <shnatsel> voldyman: as far as I'm concerned, add hooks recommendation to libgranite and merge your branch

[Sergey "Shnatsel" Davidoff (shnatsel)]

I've added hooks recommendation to packaging, see http://bazaar.launchpad.net/~elementary-os/granite/deb-packaging/revision/31
This is cleared for merging now.

review: Approve

[Sergey "Shnatsel" Davidoff (shnatsel)]

The current solution -
try { [run apport-bug] }
catch { [open link to lauchpad bug report] }
- won't work if Apport is installed but our Apport hooks are not installed because of bug 1023912 in Apport. Works fine for other distros though. I guess we'll have to live with it, because bug reports without Apport-collected info are becoming increasingly useless.

=== modified file 'lib/Widgets/AboutDialog.vala'
--- lib/Widgets/AboutDialog.vala	2012-05-30 03:31:18 +0000
+++ lib/Widgets/AboutDialog.vala	2012-07-12 16:06:22 +0000
@@ -136,7 +136,14 @@
 
             /* bug button */
             bug_button = new Button.with_label (_("Report a Problem"));
-            bug_button.pressed.connect (() => { activate_link(bug); });
+            bug_button.pressed.connect (() => {             
+                try {
+                    GLib.Process.spawn_command_line_async ("apport-bug %i".printf (Posix.getpid ()));
+                } catch (Error e) {
+                    warning ("Could Not Launch 'apport-bug'.");
+                    activate_link (bug);
+                }
+            });
             action_area.pack_start (bug_button, false, false, 0);
 
             action_area.reorder_child (bug_button, 0);