Merge ~vmpyr/ubuntu/+source/sdpa:merge-lp2131189-resolute into ubuntu/+source/sdpa:debian/sid

Proposed by Ujjwal Sarswat
Status: Needs review
Proposed branch: ~vmpyr/ubuntu/+source/sdpa:merge-lp2131189-resolute
Merge into: ubuntu/+source/sdpa:debian/sid
Diff against target: 122 lines (+56/-8)
3 files modified
debian/changelog (+50/-0)
debian/control (+4/-3)
debian/rules (+2/-5)
Reviewer Review Type Date Requested Status
Ujjwal Sarswat (community) not needed Disapprove
Nick Rosbrook (community) Needs Fixing
git-ubuntu import Pending
Review via email: mp+495703@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ujjwal Sarswat (vmpyr) wrote :
Revision history for this message
Dominik Viererbe (dviererbe) wrote :

I have one nitpick (see comment below) with the merge, otherwise it looks good.

todo: It's great that you tested that this merge builds in a PPA, but you just built it for amd64.
You also need to enable all other architectures (amd64v3, arm64, armhf, ppc64el, riscv64, s390x, ...) and verify that it builds successfully for these architectures.

suggestion: I see that the package has no autopkgtests, but I would be nice if you can run a small smoke test to verify that the binaries still work.

Revision history for this message
Ujjwal Sarswat (vmpyr) wrote :

https://launchpad.net/~vmpyr/+archive/ubuntu/merges/+packages

Have completed the builds on the rest of the architectures.

Checked if the binary is installed and working and if upgrading the package works fine.

Revision history for this message
Nick Rosbrook (enr0n) wrote :

Have you investigated why Debian does not require this change? Or is it possible to have a solution that could be forwarded to Debian?

For such a simple looking delta, it would be nice to forward it and not have to maintain anymore.

At the very least, please do add the LP bug number to the changelog as Dominik requested below.

review: Needs Fixing
Revision history for this message
Ujjwal Sarswat (vmpyr) wrote :

The delta was forwarded to debian with this bug report: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1122042

The maintainer said on the bug tracker that the bug that led to this ubuntu delta was fixed in v7.3.20-1
After doing through the changes and changelog, it seems the issue has been fixed by the maintainer. THe current version in resolute is v7.3.20-2. It was autosynced with the ubuntu delta dropped.

I am closing this MR with these changes in light.

review: Disapprove (not needed)

Unmerged commits

e0c7b85... by Ujjwal Sarswat

update-maintainer

4e59a2b... by Ujjwal Sarswat

changelog

5117dcb... by Sudip Mukherjee

Fix dependency generation for the shared mumps library.

Signed-off-by: Sudip Mukherjee <email address hidden>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 0220eca..e10b993 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+sdpa (7.3.19-1ubuntu1) resolute; urgency=medium
7+
8+ * Merge with Debian unstable. Remaining changes:
9+ - Fix dependency generation for the shared mumps library.
10+
11+ -- Ujjwal Sarswat <ujjwal.sarswat@canonical.com> Thu, 13 Nov 2025 11:28:48 +0530
12+
13 sdpa (7.3.19-1) unstable; urgency=low
14 * New upstream
15 + Change $MUMPS from 5.6.2 to 5.7.3
16@@ -8,6 +15,13 @@ sdpa (7.3.19-1) unstable; urgency=low
17 -- Makoto Yamashita <Makoto.Yamashita@comp.isct.ac.jp> Sat, 06 Sep 2025 09:00:00 +0900
18
19
20+sdpa (7.3.18-1ubuntu1) plucky; urgency=medium
21+
22+ * Merge with Debian unstable. Remaining changes:
23+ - Fix dependency generation for the shared mumps library.
24+
25+ -- Sudip Mukherjee <sudipm.mukherjee@gmail.com> Thu, 19 Dec 2024 10:29:49 +0000
26+
27 sdpa (7.3.18-1) unstable; urgency=low
28
29 * New upstream
30@@ -20,6 +34,42 @@ sdpa (7.3.18-1) unstable; urgency=low
31
32 -- Makoto Yamashita <Makoto.Yamashita@c.titech.ac.jp> Wed, 08 May 2024 09:00:00 +0900
33
34+sdpa (7.3.16+dfsg-1ubuntu3) plucky; urgency=medium
35+
36+ * No-change rebuild for mumps
37+
38+ -- Sudip Mukherjee <sudipm.mukherjee@gmail.com> Fri, 06 Dec 2024 13:24:26 +0000
39+
40+sdpa (7.3.16+dfsg-1ubuntu2) noble; urgency=medium
41+
42+ * No-change rebuild for CVE-2024-3094
43+
44+ -- William Grant <wgrant@ubuntu.com> Mon, 01 Apr 2024 15:39:18 +1100
45+
46+sdpa (7.3.16+dfsg-1ubuntu1) noble; urgency=medium
47+
48+ * Fix dependency generation for the shared mumps library.
49+
50+ -- Matthias Klose <doko@ubuntu.com> Sat, 23 Mar 2024 15:21:45 +0100
51+
52+sdpa (7.3.16+dfsg-1build3) noble; urgency=high
53+
54+ * No change rebuild against libmumps-seq-5.6t64.
55+
56+ -- Julian Andres Klode <juliank@ubuntu.com> Fri, 22 Mar 2024 17:54:20 +0100
57+
58+sdpa (7.3.16+dfsg-1build2) mantic; urgency=medium
59+
60+ * Rebuild against latest mumps
61+
62+ -- Jeremy BĂ­cha <jbicha@ubuntu.com> Sat, 02 Sep 2023 18:38:20 -0400
63+
64+sdpa (7.3.16+dfsg-1build1) lunar; urgency=medium
65+
66+ * No-change rebuild with libmumps-5.5
67+
68+ -- Graham Inggs <ginggs@ubuntu.com> Mon, 14 Nov 2022 20:36:58 +0000
69+
70 sdpa (7.3.16-1) unstable; urgency=low
71
72 * New upstream
73diff --git a/debian/control b/debian/control
74index 39c83fa..cf66ea8 100644
75--- a/debian/control
76+++ b/debian/control
77@@ -1,7 +1,8 @@
78 Source: sdpa
79 Section: math
80 Priority: optional
81-Maintainer: Makoto Yamashita <Makoto.Yamashita@comp.isct.ac.jp>
82+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
83+XSBC-Original-Maintainer: Makoto Yamashita <Makoto.Yamashita@comp.isct.ac.jp>
84 Build-Depends: debhelper-compat (=13),
85 pkgconf,
86 automake, autoconf, gfortran,
87@@ -14,7 +15,7 @@ Homepage: http://sdpa.sourceforge.net/
88 Package: sdpa
89 Architecture: any
90 Depends: ${shlibs:Depends}, ${misc:Depends},
91- libmumps-seq-${mumps-seq:Version}t64
92+ ${lib:Depends}
93 Description: High-performance package for SemiDefinite Programs
94 The software SDPA (SemiDefinite Programming Algorithm) is one of the most
95 efficient and stable software packages for solving SDPs based on the
96@@ -41,7 +42,7 @@ Description: Callable library and examples of SDPA
97 Package: sdpam
98 Architecture: any
99 Depends: ${shlibs:Depends}, ${misc:Depends},
100- libopenblas-pthread-dev, libmumps-seq-${mumps-seq:Version},
101+ libopenblas-pthread-dev, ${lib:Depends},
102 octave, libsdpa-dev
103 Description: Matlab/Octave interface of SDPA
104 This package provides SDPA-M, Matlab/Octave interface
105diff --git a/debian/rules b/debian/rules
106index 2e299be..86e5b1f 100755
107--- a/debian/rules
108+++ b/debian/rules
109@@ -37,11 +37,8 @@ MUMPS_LIBS="-ldmumps_seq -lsmumps_seq -lcmumps_seq -lzmumps_seq -lmumps_common_s
110 # "/usr/lib/$(DEB_HOST_MULTIARCH)/libdmumps_seq.a /usr/lib/$(DEB_HOST_MULTIARCH)/libmumps_common_seq.a /usr/lib/$(DEB_HOST_MULTIARCH)/libmpiseq_seq.a /usr/lib/$(DEB_HOST_MULTIARCH)/libpord_seq.a -lscotch -lesmumps"
111 DEB_CONFIGURE_EXTRA_FLAGS += --with-mumps-libs=$(MUMPS_LIBS)
112
113-
114-# LIBMUMPS_VER := $(shell dpkg --status libmumps-seq-dev | awk '/^Version:/ {print $$2}' |cut -f 1 -d "-")
115-# LIBMUMPS_VER := $(shell dpkg --status libmumps-seq-dev | grep ^Depends | tr " " "\n" | grep libmumps-seq | cut -f 3 -d "-")
116-LIBMUMPS_VER := $(shell dpkg --status libmumps-seq-dev | awk '/^Version:/ {print $$2}' |cut -f 1 -d "-" | cut -d . -f 1-2)
117-DEB_DH_GENCONTROL_ARGS_ALL = -- -Vmumps-seq:Version=$(LIBMUMPS_VER)
118+LIBMUMPS := $(shell dpkg-query -W -f '$${Depends}' libmumps-seq-dev | sed -E 's/.*(libmumps-seq[[:alnum:].-]+).*/\1/')
119+DEB_DH_GENCONTROL_ARGS_ALL = -- -Vlib:Depends=$(LIBMUMPS)
120
121 SDPA_DIR=$(CURDIR)/debian/sdpa
122 SDPAM_DIR=$(CURDIR)/debian/sdpam

Subscribers

People subscribed via source and target branches