Merge ~vmpyr/ubuntu/+source/lptools:merge-lp2131992-resolute into ubuntu/+source/lptools:debian/sid

Proposed by Ujjwal Sarswat
Status: Needs review
Proposed branch: ~vmpyr/ubuntu/+source/lptools:merge-lp2131992-resolute
Merge into: ubuntu/+source/lptools:debian/sid
Diff against target: 266 lines (+176/-2)
6 files modified
debian/changelog (+94/-0)
debian/control (+3/-2)
debian/patches/default-devel.patch (+25/-0)
debian/patches/failure-to-decompress.patch (+27/-0)
debian/patches/series (+3/-0)
debian/patches/support-credentials-file.patch (+24/-0)
Reviewer Review Type Date Requested Status
Benjamin Drung (community) Approve
git-ubuntu import Pending
Review via email: mp+496081@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ujjwal Sarswat (vmpyr) wrote :

PPA: https://launchpad.net/~vmpyr/+archive/ubuntu/merges/

Basic test:
Installing and Upgrading the package. Binary is working as expected (as much testing possible on a lxc)

Package tests:
This package contains no tests.

Note:
Build for [amd64v3](https://launchpadlibrarian.net/832474212/buildlog_ubuntu-resolute-amd64v3.lptools_0.3.0-4ubuntu1_BUILDING.txt.gz) failed because of a bug in launchpad. The other builds worked fine.

Revision history for this message
Benjamin Drung (bdrung) wrote :

0.3.0-4ubuntu1 has been sponsored by someone already.

review: Approve

Unmerged commits

dd0545a... by Ujjwal Sarswat

update-maintainer

7ed2063... by Ujjwal Sarswat

changelog

ba3417d... by Sudip Mukherjee

Drop python3-indicate from Recommends

Signed-off-by: Sudip Mukherjee <email address hidden>

bea6e34... by Sudip Mukherjee

Add support for credentials-file in lp-shell

Signed-off-by: Sudip Mukherjee <email address hidden>

00c3c68... by Sudip Mukherjee

d/p/failure-to-decompress.patch: don't crash when an attachment cannot be downloaded because it fails to decompress.

Signed-off-by: Sudip Mukherjee <email address hidden>

c1bc162... by Sudip Mukherjee

Default to devel api level, as all others are dated now

Signed-off-by: Sudip Mukherjee <email address hidden>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 9a5b3f1..b579dfa 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,13 @@
6+lptools (0.3.0-4ubuntu1) resolute; urgency=medium
7+
8+ * Merge with Debian unstable. Remaining changes:
9+ - Default to devel api level, as all others are dated now
10+ - d/p/failure-to-decompress.patch: don't crash when an attachment cannot be downloaded because it fails to decompress.
11+ - Add support for credentials-file in lp-shell
12+ - Drop python3-indicate from Recommends
13+
14+ -- Ujjwal Sarswat <ujjwal.sarswat@canonical.com> Thu, 20 Nov 2025 11:50:18 +0530
15+
16 lptools (0.3.0-4) unstable; urgency=medium
17
18 * Adopt package. (Closes: #1112689)
19@@ -14,12 +24,42 @@ lptools (0.3.0-3) unstable; urgency=medium
20
21 -- Jelmer Vernooij <jelmer@debian.org> Sun, 31 Aug 2025 22:43:50 +0100
22
23+lptools (0.3.0-2.1ubuntu1) questing; urgency=medium
24+
25+ * Merge with Debian unstable. Remaining changes:
26+ - Default to devel api level, as all others are dated now.
27+ - d/p/failure-to-decompress.patch: don't crash when an attachment
28+ cannot be downloaded because it fails to decompress.
29+ - Drop python3-indicate from Recommends.
30+ - Add support for credentials-file in lp-shell
31+ * Drop Changes:
32+ - d/control: Add runtime dependency on python3-keyring.
33+ [Fixed in 0.3.0-2.1]
34+
35+ -- Sudip Mukherjee <sudipm.mukherjee@gmail.com> Wed, 14 May 2025 19:51:20 +0100
36+
37 lptools (0.3.0-2) unstable; urgency=medium
38
39 * Add missing build-dependency on python3-setuptools. Closes: #1080661
40
41 -- Jelmer Vernooij <jelmer@debian.org> Fri, 14 Mar 2025 19:33:32 +0000
42
43+lptools (0.3.0-1ubuntu1) noble; urgency=medium
44+
45+ * Merge with Debian unstable. Remaining changes:
46+ - Default to devel api level, as all others are dated now.
47+ - d/p/failure-to-decompress.patch: don't crash when an attachment
48+ cannot be downloaded because it fails to decompress.
49+ - Drop python3-indicate from Recommends.
50+ - Add support for credentials-file in lp-shell
51+ * Drop Changes:
52+ - d/p/03_ipython_import: Use the updated import path for ipython's
53+ InteractiveShellEmbed.
54+ * New Changes:
55+ - d/control: Add runtime dependency on python3-keyring.
56+
57+ -- Sudip Mukherjee <sudipm.mukherjee@gmail.com> Thu, 08 Feb 2024 07:12:49 +0000
58+
59 lptools (0.3.0-1) unstable; urgency=medium
60
61 * New upstream release.
62@@ -36,6 +76,23 @@ lptools (0.2.0+bzr48-1) unstable; urgency=low
63
64 -- Jelmer Vernooij <jelmer@debian.org> Thu, 28 Sep 2023 13:07:42 +0100
65
66+lptools (0.2.0-7ubuntu2) mantic; urgency=medium
67+
68+ * d/p/03_ipython_import: Use the updated import path for ipython's
69+ InteractiveShellEmbed. (LP: #2017644)
70+
71+ -- Brian Murray <brian@ubuntu.com> Fri, 22 Sep 2023 14:22:16 -0700
72+
73+lptools (0.2.0-7ubuntu1) hirsute; urgency=low
74+
75+ * Merge from Debian unstable. Remaining changes:
76+ - Default to devel api level, as all others are dated now.
77+ - d/p/failure-to-decompress.patch: don't crash when an attachment
78+ cannot be downloaded because it fails to decompress.
79+ - Drop python3-indicate from Recommends.
80+
81+ -- Brian Murray <brian@ubuntu.com> Tue, 16 Feb 2021 13:55:52 -0800
82+
83 lptools (0.2.0-7) unstable; urgency=medium
84
85 [ dann frazier ]
86@@ -55,6 +112,23 @@ lptools (0.2.0-6) unstable; urgency=medium
87
88 -- Jelmer Vernooij <jelmer@debian.org> Wed, 22 Apr 2020 01:42:55 +0000
89
90+lptools (0.2.0-5ubuntu2) focal; urgency=medium
91+
92+ * Add support for credentials-file in lp-shell.
93+
94+ -- Dimitri John Ledkov <xnox@ubuntu.com> Thu, 09 Apr 2020 18:45:19 +0100
95+
96+lptools (0.2.0-5ubuntu1) focal; urgency=low
97+
98+ * Merge from Debian unstable. Remaining changes:
99+ - Default to devel api level, as all others are dated now.
100+ - d/p/failure-to-decompress.patch: don't crash when an attachment
101+ cannot be downloaded because it fails to decompress.
102+ - Move to python3.
103+ - Drop python3-indicate, python3-gtk2 from Recommends.
104+
105+ -- Steve Langasek <steve.langasek@ubuntu.com> Sat, 01 Feb 2020 19:24:44 -0800
106+
107 lptools (0.2.0-5) unstable; urgency=medium
108
109 * Add patch 02_python3: Convert to Python 3. Closes: #936967
110@@ -87,6 +161,25 @@ lptools (0.2.0-3) unstable; urgency=medium
111
112 -- Jelmer Vernooij <jelmer@debian.org> Sun, 27 Jan 2019 19:16:42 +0000
113
114+lptools (0.2.0-2ubuntu3) focal; urgency=medium
115+
116+ * Move to python3.
117+
118+ -- Steve Langasek <steve.langasek@ubuntu.com> Tue, 03 Dec 2019 21:55:45 -0800
119+
120+lptools (0.2.0-2ubuntu2) artful; urgency=medium
121+
122+ * d/p/failure-to-decompress.patch: don't crash when an attachment
123+ cannot be downloaded because it fails to decompress.
124+
125+ -- Brian Murray <brian@ubuntu.com> Tue, 11 Jul 2017 10:55:18 -0700
126+
127+lptools (0.2.0-2ubuntu1) xenial; urgency=medium
128+
129+ * Default to devel api level, as all others are dated now.
130+
131+ -- Dimitri John Ledkov <xnox@ubuntu.com> Tue, 09 Feb 2016 13:45:05 +0000
132+
133 lptools (0.2.0-2) unstable; urgency=low
134
135 [ Nathan Handler ]
136@@ -180,3 +273,4 @@ lptools (0.0.0-0ubuntu1~ppa1) karmic; urgency=low
137 * Initial release.
138
139 -- Ted Gould <ted@ubuntu.com> Fri, 11 Sep 2009 22:55:05 -0500
140+
141diff --git a/debian/control b/debian/control
142index 05ca39d..65a020e 100644
143--- a/debian/control
144+++ b/debian/control
145@@ -2,7 +2,8 @@ Source: lptools
146 Section: python
147 Priority: optional
148 Build-Depends: python3-all, dh-python, debhelper-compat (= 13), python3-setuptools, python3-keyring
149-Maintainer: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
150+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
151+XSBC-Original-Maintainer: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
152 Standards-Version: 4.7.2
153 Vcs-Git: https://salsa.debian.org/debian/lptools.git
154 Vcs-Browser: https://salsa.debian.org/debian/lptools
155@@ -13,7 +14,7 @@ Package: lptools
156 Architecture: all
157 Breaks: ubuntu-dev-tools (<< 0.129)
158 Replaces: ubuntu-dev-tools (<< 0.129)
159-Recommends: python3-chameleon, python3-indicate
160+Recommends: python3-chameleon
161 Suggests: python3-tdb
162 Depends: python3 | ipython3,
163 python3-breezy,
164diff --git a/debian/patches/default-devel.patch b/debian/patches/default-devel.patch
165new file mode 100644
166index 0000000..6f63911
167--- /dev/null
168+++ b/debian/patches/default-devel.patch
169@@ -0,0 +1,25 @@
170+Description: Default to devel api level, as all others are dated now.
171+Author: Dimitri John Ledkov <xnox@ubuntu.com>
172+
173+Index: lptools-0.2.0-7ubuntu1/bin/lp-shell
174+===================================================================
175+--- lptools-0.2.0-7ubuntu1.orig/bin/lp-shell
176++++ lptools-0.2.0-7ubuntu1/bin/lp-shell
177+@@ -29,7 +29,7 @@ def run_command(command, lp):
178+ def main():
179+ instance = 'production'
180+ valid_api_versions = ('beta', '1.0', 'devel')
181+- api_version = '1.0'
182++ api_version = 'devel'
183+
184+ usage = 'Usage: %prog [-a] [instance] [LP API version]'
185+ opt_parser = OptionParser(usage)
186+@@ -61,7 +61,7 @@ def main():
187+ api_version = args[1]
188+ else:
189+ print('E: "%s" is not a valid LP API version.' % (args[1]))
190+- print('I: Falling back to "1.0".')
191++ print('I: Falling back to "devel".')
192+
193+ if options.anonymous:
194+ launchpad = Launchpad.login_anonymously('lp-shell', instance,
195diff --git a/debian/patches/failure-to-decompress.patch b/debian/patches/failure-to-decompress.patch
196new file mode 100644
197index 0000000..40470bc
198--- /dev/null
199+++ b/debian/patches/failure-to-decompress.patch
200@@ -0,0 +1,27 @@
201+Description: continue if an attachment fails to decompress
202+ Seen with one of the attachments in bug 1701847
203+Author: Brian Murray <brian@ubuntu.com>
204+
205+--- lptools-0.2.0.orig/bin/lp-grab-attachments
206++++ lptools-0.2.0/bin/lp-grab-attachments
207+@@ -20,6 +20,7 @@
208+ #
209+ # ##################################################################
210+
211++from httplib2 import FailedToDecompressContent
212+ from optparse import OptionParser
213+ import codecs
214+ import errno
215+@@ -49,7 +50,11 @@ def download_attachments(bug, descriptio
216+ local_file.close()
217+
218+ for attachment in bug.attachments:
219+- f = attachment.data.open()
220++ try:
221++ f = attachment.data.open()
222++ except FailedToDecompressContent:
223++ print("Failed to download %s" % attachment.title)
224++ continue
225+ filename = os.path.join(os.getcwd(), bug_folder_name, f.filename)
226+ local_file = open(filename, "w")
227+ local_file.write(f.read())
228diff --git a/debian/patches/series b/debian/patches/series
229new file mode 100644
230index 0000000..8b0e184
231--- /dev/null
232+++ b/debian/patches/series
233@@ -0,0 +1,3 @@
234+default-devel.patch
235+failure-to-decompress.patch
236+support-credentials-file.patch
237diff --git a/debian/patches/support-credentials-file.patch b/debian/patches/support-credentials-file.patch
238new file mode 100644
239index 0000000..fa73a40
240--- /dev/null
241+++ b/debian/patches/support-credentials-file.patch
242@@ -0,0 +1,24 @@
243+Description: Add support for credentials-file in lp-shell.
244+Author: Dimitri John Ledkov <xnox@ubuntu.com>
245+
246+
247+--- lptools-0.2.0.orig/bin/lp-shell
248++++ lptools-0.2.0/bin/lp-shell
249+@@ -39,6 +39,9 @@ def main():
250+ opt_parser.add_option('-c', type=str,
251+ dest='command', default=None,
252+ help='Run code passed as string.')
253++ opt_parser.add_option('--credentials-file', type=str,
254++ default=None,
255++ help='Use unecrypted credentials file')
256+ opt_parser.add_option('--ipython', action='store_const',
257+ dest='shell', const='ipython', default="ipython",
258+ help='Use ipython shell (default).')
259+@@ -70,6 +73,7 @@ def main():
260+ '"%s":' % (instance, api_version))
261+ else:
262+ launchpad = Launchpad.login_with('lp-shell', instance,
263++ credentials_file=options.credentials_file,
264+ version=api_version)
265+ banner = 'Connected to LP service "%s" with API version "%s":' % \
266+ (instance, api_version)

Subscribers

People subscribed via source and target branches