> Hi Vlad,
>
>
> General comments:
>
> - I think this MP should wait until 5.6.11-60.3 with the fix for bug
> #1172591 is released. Then the test suite should use 5.6.11-60.30
> for testing instead of the custom build
The fix is released.
> - there should be a separate fix for bug #1177182 for both 2.0 and
> 2.1, and again, this branch should be rebased once the fix is merged to
> trunks.
The fix for 2.1 is merged and for 2.0 is approved for merging.
> - xtrabackup_arch_search_files() should use msg() instead of
> fprintf(stderr,...)
Fixed.
> >> - s/alligned to the up of log file block/aligned up to the log
> >> block size/
> >
> > Done.
> >
>
> Not fully done, it is "aligned" (single "l"), not "alligned".
Done.
> OK, I see the problem now, reported as bug #1179193. This means we have
> to fix that bug separately in both 2.0 and 2.1, and then rebase this
> branch on 2.1 trunk with that fix included.
I explored this problem more deeply and found out that the problem is "apply archived log" specific. See my comment to the bug report and
if (srv_apply_log_only) { goto skip_processes;
}
strings in innobase_start_or_create_for_mysql().
> >> - the test case doesn't work for me (fails with "table 'test.t1'
> >> doesn't exist" when run against PS 5.6 with log archiving enabled)
> >>
> >
> > I need your assistance here because I can't reproduce this on my
> > environment and, as I understood, on Jenkins environment too(see
> > http://jenkins.percona.com/view/XtraBackup/job/percona-
> xtrabackup-2.1-param/298/#showFailuresLink).
> >
>
> I tried to repeat the test, but your branch doesn't build for me now, it
> fails as follows:
>
> [ 70%] Building CXX object
> libmysqld/CMakeFiles/sql_embedded.dir/__/sql/field_conv.cc.o
> /Users/kaa/src/launchpad/percona-xtrabackup/2.1-apply-archived-logs-
> innodb5.6/mysql-5.6/storage/innobase/log/log0recv.cc:3142:3:
> error: no matching function for call to
> 'log_checkpoint_get_nth_group_info'
> log_checkpoint_get_nth_group_info(buf, group->id,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /Users/kaa/src/launchpad/percona-xtrabackup/2.1-apply-archived-logs-
> innodb5.6/mysql-5.6/storage/innobase/include/log0log.h:286:1:
> note: candidate function not viable: no known
> conversion from 'lsn_t *' (aka 'unsigned long long *') to 'ulint
> *' (aka 'unsigned long *') for 3rd argument;
> log_checkpoint_get_nth_group_info(
> ^
> 1[ 70%] error generated.
Fixed. The invocation of log_checkpoint_get_nth_group_info() is commented in this place because there is no need to read archived_file_no and archived_offset. They are calculated another way.
> Hi Vlad,
>
>
> General comments:
>
> - I think this MP should wait until 5.6.11-60.3 with the fix for bug
> #1172591 is released. Then the test suite should use 5.6.11-60.30
> for testing instead of the custom build
The fix is released.
> - there should be a separate fix for bug #1177182 for both 2.0 and
> 2.1, and again, this branch should be rebased once the fix is merged to
> trunks.
The fix for 2.1 is merged and for 2.0 is approved for merging.
> - xtrabackup_ arch_search_ files() should use msg() instead of
> fprintf(stderr,...)
Fixed.
> >> - s/alligned to the up of log file block/aligned up to the log
> >> block size/
> >
> > Done.
> >
>
> Not fully done, it is "aligned" (single "l"), not "alligned".
Done.
> OK, I see the problem now, reported as bug #1179193. This means we have log_only) {
goto skip_processes; start_or_ create_ for_mysql( ).
> to fix that bug separately in both 2.0 and 2.1, and then rebase this
> branch on 2.1 trunk with that fix included.
I explored this problem more deeply and found out that the problem is "apply archived log" specific. See my comment to the bug report and
if (srv_apply_
}
strings in innobase_
> >> - the test case doesn't work for me (fails with "table 'test.t1' jenkins. percona. com/view/ XtraBackup/ job/percona- 2.1-param/ 298/#showFailur esLink) . CMakeFiles/ sql_embedded. dir/__/ sql/field_ conv.cc. o kaa/src/ launchpad/ percona- xtrabackup/ 2.1-apply- archived- logs- 6/mysql- 5.6/storage/ innobase/ log/log0recv. cc:3142: 3: _get_nth_ group_info' get_nth_ group_info( buf, group->id, ~~~~~~~ ~~~~~~~ ~~~~~~~ ~~~~~ kaa/src/ launchpad/ percona- xtrabackup/ 2.1-apply- archived- logs- 6/mysql- 5.6/storage/ innobase/ include/ log0log. h:286:1: get_nth_ group_info( get_nth_ group_info( ) is commented in this place because there is no need to read archived_file_no and archived_offset. They are calculated another way.
> >> doesn't exist" when run against PS 5.6 with log archiving enabled)
> >>
> >
> > I need your assistance here because I can't reproduce this on my
> > environment and, as I understood, on Jenkins environment too(see
> > http://
> xtrabackup-
> >
>
> I tried to repeat the test, but your branch doesn't build for me now, it
> fails as follows:
>
> [ 70%] Building CXX object
> libmysqld/
> /Users/
> innodb5.
> error: no matching function for call to
> 'log_checkpoint
> log_checkpoint_
> ^~~~~~~
> /Users/
> innodb5.
> note: candidate function not viable: no known
> conversion from 'lsn_t *' (aka 'unsigned long long *') to 'ulint
> *' (aka 'unsigned long *') for 3rd argument;
> log_checkpoint_
> ^
> 1[ 70%] error generated.
Fixed. The invocation of log_checkpoint_