Percona Server moved to https://jira.percona.com/projects/PS

Code review comment for lp:~vlad-lesin/percona-server/5.6-xtrabackup-apply-logs-fixes

  1. 5.6-xtrabackup-apply-logs-fixes
  2. Merge into 5.6
Revision history for this message
Vlad Lesin (vlad-lesin) wrote :

> Other calls of create_log_files_rename() don't need that, so doing it
> unconditionally inside create_log_files_rename() does not look right.
>
> I'd also add a comment in that code explaining that create_log_files() can
> increase system LSN, so we have to update FIL_PAGE_FILE_FLUSH_LSN in data
> files.
>
> Please also add the bug # reference and fix typos in revision comments before
> resubmitting.

Done. Waiting for jenkins testing results.

« Back to merge proposal