Code review comment for lp:~vlad-lesin/percona-server/5.6-sql_timeout_twitter

Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :

Vlad,

I see you encountered same issue as I did also. performance_schema *digest* tables are rely heavily on sql_yacc.yy grammar. So if someone just add new token (or even rule?) many of statement's digests will change.

I very dislike it as
1. There is a need to almost completely rewrite several *.result in perfscehma suite
2. There is no way to merge for example this branch and lp:~sergei.glushchenko/percona-server/ps56-univ-log-archive as both touch sql_yacc.yy. As resulting MD5 hashes will depend on changes made in both branches. The only possible way is once one of the branges been merged, update another one and recalculate digests in test cases.

Do you have any thoughts on how to workaround this?

Thanks,
Sergei

« Back to merge proposal