Percona Server moved to https://jira.percona.com/projects/PS

Code review comment for lp:~vlad-lesin/percona-server/5.6-query_response_time-rw-commands

  1. 5.6-query_response_time-rw-commands
  2. Merge into 5.6
Revision history for this message
Vlad Lesin (vlad-lesin) wrote :

> As discussed yesterday on IRC:
>
> - THD::update_server_status uses utime_after_query too
> do you know whether updating the field might cause the change of behavior
> somewhere else?
I have checked the code and did not find side effects now. Moreover I ran tests and everything seems ok: http://jenkins.percona.com/view/PS%205.6/job/percona-server-5.6-param/804/ .

> -
> 64 - query_response_time_collect(thd->utime_after_query -
> thd->utime_after_lock);
> 65 + query_response_time_collect(query_type, thd->utime_after_query -
> thd->start_utime);
> before: utime after lock
> after: start utime
> why?

I have changed it for some reason, but unfortunately I don't remember the reason. I tested "utime_after_lock" variant both with regression test and manually with different test cases and it works well so I decided to revert this line.

« Back to merge proposal