Code review comment for lp:~vlad-lesin/percona-server/5.5-mysqlbinlog-replacedb

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

> > > > - The warning for "a->b,c->d" syntax seems to be repeated for
> > > > each comma, so "a->b,c->d,e->f" would print the warning twice,
> > > > which is unnecessary.
> > > Fixed.
> >
> > What was the fix?
> ...
> > Or am I missing something here?
>
> Yes, you are right, I was sure I fixed it. But somehow I did not. I believe it
> is fixed now.

The flag is local to OPT_REWRITE_DB, so --rewrite-db="a->b,c->d,e->f" --rewrite-db="g->h,i->j,k->l", would still print the warning twice, wouldn't it?

> As well I have rebased the code to the newest 5.5.

Uhm, why? This is not a GCA branch anymore then?

review: Needs Fixing

« Back to merge proposal