Code review comment for lp:~vlad-lesin/percona-server/5.5-mysqlbinlog-replacedb

Revision history for this message
Vlad Lesin (vlad-lesin) wrote :

> > > - The warning for "a->b,c->d" syntax seems to be repeated for
> > > each comma, so "a->b,c->d,e->f" would print the warning twice,
> > > which is unnecessary.
> > Fixed.
> What was the fix?
> Or am I missing something here?

Yes, you are right, I was sure I fixed it. But somehow I did not. I believe it is fixed now.

> > > - Does running our testcases on MySQL 5.7 give the expected
> > > results?
> > No because 5.7 does not support our syntax.
> Right, but accounted for syntax changes? Does our and their order of applying
> --database= --rewrite-db= agree?

Yes. For 5.7 dump_local_log_entries() and dump_remote_log_entries() invoke Log_event::read_log_event() where db name is rewritten and then invoke process_event() where db name is checked by shall_skip_database() for filtering out. So db name is rewritten and then filtered like in PS.

As well I have rebased the code to the newest 5.5. Here id jenkins testing:

« Back to merge proposal