Code review comment for lp:~vlad-lesin/percona-server/5.5-mysqlbinlog-replacedb

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

> > - Rewrite rules are not applied to CREATE_FILE_EVENT. This
> > wouldn't be an issue in itself, but these events are filtered
> > against --database, thus, depending on how the previous item is
> > resolved, these events might need rewrite-db application too,
> > so that they can be filtered properly. This would also need a
> > testcase.
> I added the code which replaces db name in the event processing, but I
> have no idea how to test it as there is the following comment in
> log_event.h:
> "The events which really update data are Query_log_event,
> Execute_load_query_log_event and old Load_log_event and
> Execute_load_log_event events (Execute_load_query is used together with
> Begin_load_query and Append_block events to replicate LOAD DATA INFILE.
> Create_file/Append_block/Execute_load (which includes Load_log_event)
> were used to replicate LOAD DATA before the 5.0.3)."
> So CREATE_FILE_EVENT were used before 5.0.3.

Ah sorry I missed this, this is a non-issue then.

« Back to merge proposal