Code review comment for lp:~vlad-lesin/percona-server/5.5-mysqlbinlog-replacedb

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

> Laurynas Biveinis <email address hidden> writes:
> > - Oracle has implemented this functionality in 5.7.1. From the
> > user perspective the difference is option syntax, ours:
> > --rewrite-db='a->b,c->d'
> > theirs:
> > --rewrite-db='a->b' --rewrite-db='c->d'
> > To ensure smooth migration once we switch to their
> > implementation in 5.7, please test both syntaxes in the
> > testcase.
>
> We should probably throw a warning if the user uses the syntax that will
> break in 5.7, as really we should just take the Oracle impl in 5.7.
>
>
> --
> Stewart Smith

We can also (if the customer does not object) take the 5.7 syntax in 5.5 already for a bit simpler code/testcases.

« Back to merge proposal