Code review comment for lp:~vlad-lesin/percona-server/5.5-bugs-1268729-1268735

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

>
> > - Instead of own log grepper in Perl use one already provided:
> > include/search_pattern.inc or search_pattern_in_file.inc,
> > depending on whether you prefer testcase abort or a result file
> > mismatch in case of the pattern not found. (s_p_in_file.inc
> > exists in both 5.5 and 5.6, s_p.inc only in 5.6. In case you
> > want that one, just bzr add it with the correct file id to
> > 5.5).
>
> I have not found include/search_pattern.inc in both 5.5 and 5.6, so
> include/log_grep.inc is used instead it.

There is search_pattern_in_file.inc. log_grep.inc is OK too, except that it would be nice to remove it from the 5.7 port.

« Back to merge proposal