Code review comment for lp:~vlad-lesin/percona-server/5.5-bug-1354988

Revision history for this message
Vlad Lesin (vlad-lesin) wrote :

> - Grepping mysql_show_grants call tree for my_strcasecmp shows
> that the issue is fixed for database-level grants but should
> continue to exist for table, column and routine-level
> grants. This becomes quite unorthogonal, can you check this,
> expand the testcase, and fix this too?
Yes, you are right, I fixed mysql_show_grants() and it's subroutines so host name is compared with wildcards for all grant levels.

> - Once the patch is reviewed, please make a patch against MySQL
> and submit by OCA to upstream 53645.
Will do after code review.

http://jenkins.percona.com/view/PS%205.5/job/percona-server-5.5-param/1090/

« Back to merge proposal