Merge lp:~vlad-lesin/percona-server/5.5-bug-1038940-table_cache_speed_up into lp:percona-server/5.5

[Vlad Lesin]

This MP is port of this http://lists.mysql.com/commits/121507 patch to 5.5(see issue #25137). The main idea of this patch is to replace linked list of opened tables with hash-table to improve performance of open table lookup mechanism.

Jenkins test:
http://jenkins.percona.com/view/PS%205.5/job/percona-server-5.5-param/610

[lp:~vlad-lesin/percona-server/5.5-bug-1038940-table_cache_speed_up]

387. By Stewart Smith on 2013-01-03

Merge lp:~lp-dev-merge-bot/percona-server/staging-5.1 containing lp:~vlad-lesin/percona-server/5.1-bug1049871-injections-gca to 5.5 - one small conflict

388. By Stewart Smith on 2013-01-07

reverse the bad merge from previous revision (r387 - Merge lp:~lp-dev-merge-bot/percona-server/staging-5.1 containing lp:~vlad-lesin/percona-server/5.1-bug1049871-injections-gca to 5.5 - one small conflict
modified). This merge was incorrect and caused rpl.rpl_mdev382 to fail

389. By <email address hidden> on 2013-01-07

Merge lp:~hrvojem/percona-server/bug1070930-5.5

390. By <email address hidden> on 2013-01-07

Merge lp:~laurynas-biveinis/percona-server/BT-16274-bug1087202-10872128-5.5-2

391. By <email address hidden> on 2013-01-08

Merge lp:~hrvojem/percona-server/rn-5.5.28-29.3

392. By <email address hidden> on 2013-01-08

Empty merge from Percona Server 5.1

393. By <email address hidden> on 2013-01-09

Merge lp:~percona-core/percona-server/release-5.5.28-29.3

394. By <email address hidden> on 2013-01-09

Merge lp:~hrvojem/percona-server/rn-5.5.28-29.3-r2

395. By <email address hidden> on 2013-01-09

Merge lp:~hrvojem/percona-server/rn-5.1.66-14.2-r2-5.5

396. By <email address hidden> on 2013-01-09

Empty merge from Percona Server 5.1

397. By <email address hidden> on 2013-01-15

Merge lp:~stewart/percona-server/5.5.29

398. By <email address hidden> on 2013-01-17

Merge lp:~hrvojem/percona-server/bug1092106-5.5

399. By <email address hidden> on 2013-01-17

Empty merge from Percona Server 5.1

400. By <email address hidden> on 2013-01-17

Merge lp:~stewart/percona-server/5.5-5.1.66-14.1-merge

401. By <email address hidden> on 2013-01-18

Empty merge from Percona Server 5.1

402. By Stewart Smith on 2013-01-18

merge 5.1.66-14.2 release branch

403. By <email address hidden> on 2013-01-18

Merge lp:~hrvojem/percona-server/rn-5.1.67-14.3-5.5

404. By <email address hidden> on 2013-01-18

Empty merge from Percona Server 5.1

405. By <email address hidden> on 2013-01-18

Merge lp:~sergei.glushchenko/percona-server/ST-27220-bug1042946

406. By <email address hidden> on 2013-01-19

Empty merge from Percona Server 5.1

[Laurynas Biveinis (laurynas-biveinis)]

At line 193, "if (my_hash_inited(...))" should be !my_hash_inited instead I think.

Also, please make a 5.6 MP (without a bzr merge).

review: Needs Fixing

[lp:~vlad-lesin/percona-server/5.5-bug-1038940-table_cache_speed_up]

407. By <email address hidden> on 2013-01-20

Merge lp:~laurynas-biveinis/percona-server/bug1100159-5.5

408. By <email address hidden> on 2013-01-21

Merge lp:~sergei.glushchenko/percona-server/ps55-bug1017192

409. By <email address hidden> on 2013-01-21

Empty merge from Percona Server 5.1

410. By <email address hidden> on 2013-01-28

Merge lp:~laurynas-biveinis/percona-server/BT-16724-xtradb-bmp-requests-5.5

411. By <email address hidden> on 2013-01-29

Empty merge from Percona Server 5.1

412. By <email address hidden> on 2013-02-04

Merge lp:~laurynas-biveinis/percona-server/BT-16274-bug1082437-5.5

413. By <email address hidden> on 2013-02-05

Empty merge from Percona Server 5.1

414. By <email address hidden> on 2013-02-05

Merge lp:~laurynas-biveinis/percona-server/BT-16274-bug1083596-5.5

415. By <email address hidden> on 2013-02-05

Merge lp:~laurynas-biveinis/percona-server/BT-16274-bug1083669-5.5

416. By <email address hidden> on 2013-02-05

Merge lp:~laurynas-biveinis/percona-server/bug1083058-5.5

417. By <email address hidden> on 2013-02-06

Empty merge from Percona Server 5.1

418. By <email address hidden> on 2013-02-06

Merge lp:~stewart/percona-server/5.5-bug986247-remove-optimizer-fix

419. By <email address hidden> on 2013-02-06

Merge lp:~abychko/percona-server/bug1099809

420. By <email address hidden> on 2013-02-06

Merge lp:~hrvojem/percona-server/bug1065771-5.5

421. By <email address hidden> on 2013-02-06

Merge lp:~laurynas-biveinis/percona-server/bug1100178-1100643-5.5

422. By <email address hidden> on 2013-02-06

Empty merge from Percona Server 5.1

423. By <email address hidden> on 2013-02-06

Merge lp:~abychko/percona-server/bug1103328

424. By <email address hidden> on 2013-02-06

Merge lp:~laurynas-biveinis/percona-server/bug1105709-5.5

425. By <email address hidden> on 2013-02-06

Merge lp:~hrvojem/percona-server/ps-25

426. By <email address hidden> on 2013-02-06

Merge lp:~abychko/percona-server/bug881944

427. By <email address hidden> on 2013-02-07

Empty merge from Percona Server 5.1

428. By <email address hidden> on 2013-02-07

Merge lp:~laurynas-biveinis/percona-server/bpage-io-fix

429. By <email address hidden> on 2013-02-07

Empty merge from Percona Server 5.1

430. By <email address hidden> on 2013-02-07

Empty merge from Percona Server 5.1

431. By <email address hidden> on 2013-02-07

Empty merge from Percona Server 5.1

432. By <email address hidden> on 2013-02-07

Merge lp:~laurynas-biveinis/percona-server/bug1101030

433. By <email address hidden> on 2013-02-07

Merge lp:~laurynas-biveinis/percona-server/BT-16274-bug1111226-5.5

434. By <email address hidden> on 2013-02-08

Merge lp:~laurynas-biveinis/percona-server/bug1114612-5.5

435. By <email address hidden> on 2013-02-08

Merge lp:~laurynas-biveinis/percona-server/BT-16274-bug1108874-5.5

436. By <email address hidden> on 2013-02-09

Empty merge from Percona Server 5.1

437. By <email address hidden> on 2013-02-09

Empty merge from Percona Server 5.1

438. By <email address hidden> on 2013-02-11

Merge lp:~laurynas-biveinis/percona-server/slow-log-fixes-5.5

439. By Stewart Smith on 2013-02-11

null merge 5.1 implementation of slow query log fixes, as 5.5 is sep impl

440. By <email address hidden> on 2013-02-13

Merge lp:~laurynas-biveinis/percona-server/BT-16274-bug1105726-5.5

441. By <email address hidden> on 2013-02-13

Merge lp:~hrvojem/percona-server/bug1092189-5.5

442. By <email address hidden> on 2013-02-13

Empty merge from Percona Server 5.1

443. By <email address hidden> on 2013-02-13

Empty merge from Percona Server 5.1

444. By <email address hidden> on 2013-02-14

Empty merge from Percona Server 5.1

445. By <email address hidden> on 2013-02-14

Merge lp:~sergei.glushchenko/percona-server/55-tp

446. By Alexey Kopytov on 2013-02-15

Bug #1126077: Remove clang warnings

Fixed an annoying warning in the InnoDB code produced by clang.

This is a backport from 5.6.

447. By <email address hidden> on 2013-02-19

Merge lp:~gl-az/percona-server/BT-26980-5.5-bug1068210

448. By <email address hidden> on 2013-02-20

Merge lp:~laurynas-biveinis/percona-server/bug1089265-5.5

449. By <email address hidden> on 2013-02-20

Merge lp:~akopytov/percona-server/bug1125259

450. By <email address hidden> on 2013-02-20

Merge lp:~laurynas-biveinis/percona-server/bug1117067-5.5

451. By Vlad Lesin on 2013-02-24

As the number of open tables is increased, table lookup
(testing if a table is already open) and (in particular)
the case when a table is not open, became increasingly more
expensive.

The problem was caused by the open table lookup mechanism,
which was based on traversing a linked list comparing the
file names.

As the list was replaced by a hash table, the lookup
time dropped significantly when used on systems with
a large number of open tables.

The original patch can be found here:
http://lists.mysql.com/commits/121507

[Vlad Lesin (vlad-lesin)]

> At line 193, "if (my_hash_inited(...))" should be !my_hash_inited instead I
> think.

Fixed. As well unnecessary changes from mi_panic.c are removed. Currently 5.1, 5.5 and 5.6 patches are almost the same.

> Also, please make a 5.6 MP (without a bzr merge).
Done. See bug related branches.

Jenkins: http://jenkins.percona.com/view/PS%205.5/job/percona-server-5.5-param/692/

[Laurynas Biveinis (laurynas-biveinis)]

The patch is OK, but I'll have to ask you to redo it as a GCA involving all three 5.1/5.5/5.6.

review: Needs Fixing

Unmerged revisions

451. By Vlad Lesin on 2013-02-24

As the number of open tables is increased, table lookup
(testing if a table is already open) and (in particular)
the case when a table is not open, became increasingly more
expensive.

The problem was caused by the open table lookup mechanism,
which was based on traversing a linked list comparing the
file names.

As the list was replaced by a hash table, the lookup
time dropped significantly when used on systems with
a large number of open tables.

The original patch can be found here:
http://lists.mysql.com/commits/121507

=== modified file 'Percona-Server/storage/myisam/ha_myisam.cc'
--- Percona-Server/storage/myisam/ha_myisam.cc	2012-10-17 03:47:45 +0000
+++ Percona-Server/storage/myisam/ha_myisam.cc	2013-02-24 23:11:32 +0000
@@ -2191,6 +2191,9 @@
   myisam_hton->flags= HTON_CAN_RECREATE | HTON_SUPPORT_LOG_TABLES;
   myisam_hton->is_supported_system_table= myisam_is_supported_system_table;
 
+  if (mi_init_open_table_hash(table_cache_size))
+    return 1;
+
   return 0;
 }
 

=== modified file 'Percona-Server/storage/myisam/mi_close.c'
--- Percona-Server/storage/myisam/mi_close.c	2012-02-16 09:48:16 +0000
+++ Percona-Server/storage/myisam/mi_close.c	2013-02-24 23:11:32 +0000
@@ -54,7 +54,7 @@
     info->opt_flag&= ~(READ_CACHE_USED | WRITE_CACHE_USED);
   }
   flag= !--share->reopen;
-  myisam_open_list=list_delete(myisam_open_list,&info->open_list);
+  my_hash_delete(&myisam_open_table_hash, (uchar *) info);
   mysql_mutex_unlock(&share->intern_lock);
 
   my_free(mi_get_rec_buff_ptr(info, info->rec_buff));

=== modified file 'Percona-Server/storage/myisam/mi_dbug.c'
--- Percona-Server/storage/myisam/mi_dbug.c	2011-06-30 15:46:53 +0000
+++ Percona-Server/storage/myisam/mi_dbug.c	2013-02-24 23:11:32 +0000
@@ -181,14 +181,14 @@
 my_bool check_table_is_closed(const char *name, const char *where)
 {
   char filename[FN_REFLEN];
-  LIST *pos;
+  uint idx;
   DBUG_ENTER("check_table_is_closed");
 
   (void) fn_format(filename,name,"",MI_NAME_IEXT,4+16+32);
   mysql_mutex_lock(&THR_LOCK_myisam);
-  for (pos=myisam_open_list ; pos ; pos=pos->next)
+  for (idx= 0; idx < myisam_open_table_hash.records; ++idx)
   {
-    MI_INFO *info=(MI_INFO*) pos->data;
+    MI_INFO *info=(MI_INFO*) my_hash_element(&myisam_open_table_hash, idx);
     MYISAM_SHARE *share=info->s;
     if (!strcmp(share->unique_file_name,filename))
     {

=== modified file 'Percona-Server/storage/myisam/mi_keycache.c'
--- Percona-Server/storage/myisam/mi_keycache.c	2011-06-30 15:46:53 +0000
+++ Percona-Server/storage/myisam/mi_keycache.c	2013-02-24 23:11:32 +0000
@@ -138,16 +138,16 @@
 void mi_change_key_cache(KEY_CACHE *old_key_cache,
 			 KEY_CACHE *new_key_cache)
 {
-  LIST *pos;
+  uint idx;
   DBUG_ENTER("mi_change_key_cache");
 
   /*
     Lock list to ensure that no one can close the table while we manipulate it
   */
   mysql_mutex_lock(&THR_LOCK_myisam);
-  for (pos=myisam_open_list ; pos ; pos=pos->next)
+  for (idx= 0; idx < myisam_open_table_hash.records; ++idx)
   {
-    MI_INFO *info= (MI_INFO*) pos->data;
+    MI_INFO *info=(MI_INFO*) my_hash_element(&myisam_open_table_hash, idx);
     MYISAM_SHARE *share= info->s;
     if (share->key_cache == old_key_cache)
       mi_assign_to_key_cache(info, (ulonglong) ~0, new_key_cache);

=== modified file 'Percona-Server/storage/myisam/mi_open.c'
--- Percona-Server/storage/myisam/mi_open.c	2012-10-31 13:02:53 +0000
+++ Percona-Server/storage/myisam/mi_open.c	2013-02-24 23:11:32 +0000
@@ -37,23 +37,76 @@
 }
 
 
-/******************************************************************************
-** Return the shared struct if the table is already open.
-** In MySQL the server will handle version issues.
-******************************************************************************/
-
+/*
+  Get the value used as hash key (helper function for the 
+  open table hash).  Function is used as a callback 
+  from the hash table
+*/
+static uchar *mi_open_table_hash_key(const uchar *record, size_t *length,
+                                     my_bool not_used __attribute__((unused)))
+{
+  MI_INFO *info= (MI_INFO *) record;
+  *length= info->s->unique_name_length;
+  return (uchar*) info->s->unique_file_name;
+}
+
+/**
+  Initialize open table hash
+ 
+  Function is normally called from myisam_init
+  with the system variable table_cache_size used
+  as hash_size.
+
+  @param[in]      hash_size Initial has size (elements)
+  @return         inidicates success or failure of initialization
+    @retval 0 success
+    @retval 1 failure
+
+*/
+int mi_init_open_table_hash(ulong hash_size)
+{
+  if (hash_size == 0)
+    hash_size= 32; /* default hash size */
+
+  if (my_hash_init(&myisam_open_table_hash, &my_charset_filename, 
+                   hash_size, 0, 0, mi_open_table_hash_key, 0, 0))
+    return 1; /* error */
+  
+  return 0;
+}
+
+
+/**
+  Retrieve the shared struct if the table is already
+  open (i.e  in the open table hash)
+
+  @param[in] filename table file name
+  @return    shared struct, 0 if not in the cache
+*/
 MI_INFO *test_if_reopen(char *filename)
 {
-  LIST *pos;
+  HASH_SEARCH_STATE current_record;
+  int len= strlen(filename);
 
-  for (pos=myisam_open_list ; pos ; pos=pos->next)
+  MI_INFO *info= (MI_INFO*) my_hash_first(&myisam_open_table_hash, 
+                                          (uchar *) filename, 
+                                          len, &current_record);
+  /*
+    There might be more than one instance of a table share for
+    a given table in the hash table.  We're interested in the one with 
+    last_version set, so we iterate until we find it
+  */
+  while (info)
   {
-    MI_INFO *info=(MI_INFO*) pos->data;
     MYISAM_SHARE *share=info->s;
-    if (!strcmp(share->unique_file_name,filename) && share->last_version)
-      return info;
+    if (share->last_version)
+      break;
+    
+    info= (MI_INFO*) my_hash_next(&myisam_open_table_hash, 
+                                  (uchar *) filename, 
+                                  len, &current_record);
   }
-  return 0;
+  return info;
 }
 
 
@@ -623,8 +676,9 @@
 
   *m_info=info;
   thr_lock_data_init(&share->lock,&m_info->lock,(void*) m_info);
-  m_info->open_list.data=(void*) m_info;
-  myisam_open_list=list_add(myisam_open_list,&m_info->open_list);
+
+  if (my_hash_insert(&myisam_open_table_hash, (uchar *) m_info))
+    goto err;
 
   mysql_mutex_unlock(&THR_LOCK_myisam);
 

=== modified file 'Percona-Server/storage/myisam/mi_panic.c'
--- Percona-Server/storage/myisam/mi_panic.c	2011-06-30 15:46:53 +0000
+++ Percona-Server/storage/myisam/mi_panic.c	2013-02-24 23:11:32 +0000
@@ -27,22 +27,36 @@
 int mi_panic(enum ha_panic_function flag)
 {
   int error=0;
-  LIST *list_element,*next_open;
   MI_INFO *info;
+  uint idx;
   DBUG_ENTER("mi_panic");
 
   mysql_mutex_lock(&THR_LOCK_myisam);
-  for (list_element=myisam_open_list ; list_element ; list_element=next_open)
+
+  if (!my_hash_inited(&myisam_open_table_hash))
+    goto finish;
+
+  if (flag == HA_PANIC_CLOSE)
   {
-    next_open=list_element->next;		/* Save if close */
-    info=(MI_INFO*) list_element->data;
-    switch (flag) {
-    case HA_PANIC_CLOSE:
+    while (myisam_open_table_hash.records)
+    {
+      /*
+         As long as there are records in the hash, fetch the
+         first, and close it.
+      */
+      info=(MI_INFO*) my_hash_element(&myisam_open_table_hash, 0);
       mysql_mutex_unlock(&THR_LOCK_myisam);     /* Not exactly right... */
       if (mi_close(info))
-	error=my_errno;
+        error= my_errno;
       mysql_mutex_lock(&THR_LOCK_myisam);
-      break;
+    }
+  }
+
+  for (idx= 0; idx < myisam_open_table_hash.records; ++idx)
+  {
+    info=(MI_INFO*) my_hash_element(&myisam_open_table_hash, idx);
+    switch (flag) {
+    case HA_PANIC_CLOSE: break;
     case HA_PANIC_WRITE:		/* Do this to free databases */
 #ifdef CANT_OPEN_FILES_TWICE
       if (info->s->options & HA_OPTION_READ_ONLY_DATA)
@@ -111,6 +125,8 @@
     (void) mi_log(0);				/* Close log if neaded */
     ft_free_stopwords();
   }
+
+finish:
   mysql_mutex_unlock(&THR_LOCK_myisam);
   if (!error)
     DBUG_RETURN(0);

=== modified file 'Percona-Server/storage/myisam/mi_static.c'
--- Percona-Server/storage/myisam/mi_static.c	2011-06-30 15:46:53 +0000
+++ Percona-Server/storage/myisam/mi_static.c	2013-02-24 23:11:32 +0000
@@ -22,7 +22,7 @@
 #include "myisamdef.h"
 #endif
 
-LIST	*myisam_open_list=0;
+HASH    myisam_open_table_hash;
 uchar	myisam_file_magic[]=
 { (uchar) 254, (uchar) 254,'\007', '\001', };
 uchar	myisam_pack_file_magic[]=

=== modified file 'Percona-Server/storage/myisam/myisamchk.c'
--- Percona-Server/storage/myisam/myisamchk.c	2012-10-30 14:10:42 +0000
+++ Percona-Server/storage/myisam/myisamchk.c	2013-02-24 23:11:32 +0000
@@ -88,6 +88,12 @@
   get_options(&argc,(char***) &argv);
   myisam_quick_table_bits=decode_bits;
   error=0;
+  if (mi_init_open_table_hash(0))
+  {
+    fprintf(stderr, "Can't initialize MyISAM storage engine\n");
+    exit(-1);
+  }
+
   while (--argc >= 0)
   {
     int new_error=myisamchk(&check_param, *(argv++));

=== modified file 'Percona-Server/storage/myisam/myisamdef.h'
--- Percona-Server/storage/myisam/myisamdef.h	2012-05-10 07:49:14 +0000
+++ Percona-Server/storage/myisam/myisamdef.h	2013-02-24 23:11:32 +0000
@@ -22,6 +22,7 @@
 #include <my_pthread.h>
 #include <thr_lock.h>
 #include <mysql/psi/mysql_file.h>
+#include "hash.h"
 
 /* undef map from my_nosys; We need test-if-disk full */
 #if defined(my_write)
@@ -281,7 +282,6 @@
   uint	data_changed;			/* Somebody has changed data */
   uint	save_update;			/* When using KEY_READ */
   int	save_lastinx;
-  LIST	open_list;
   IO_CACHE rec_cache;			/* When cacheing records */
   uint  preload_buff_size;              /* When preloading indexes */
   myf lock_wait;			/* is 0 or MY_DONT_WAIT */
@@ -465,8 +465,7 @@
 #endif
 
 	/* Some extern variables */
-
-extern LIST *myisam_open_list;
+extern HASH myisam_open_table_hash;
 extern uchar myisam_file_magic[], myisam_pack_file_magic[];
 extern uint myisam_read_vec[], myisam_readnext_vec[];
 extern uint myisam_quick_table_bits;
@@ -748,6 +747,7 @@
 void mi_disable_non_unique_index(MI_INFO *info, ha_rows rows);
 
 extern MI_INFO *test_if_reopen(char *filename);
+extern int mi_init_open_table_hash(ulong size);
 my_bool check_table_is_closed(const char *name, const char *where);
 int mi_open_datafile(MI_INFO *info, MYISAM_SHARE *share, const char *orn_name,
                      File file_to_dup);

=== modified file 'Percona-Server/storage/myisam/myisampack.c'
--- Percona-Server/storage/myisam/myisampack.c	2011-06-30 15:46:53 +0000
+++ Percona-Server/storage/myisam/myisampack.c	2013-02-24 23:11:32 +0000
@@ -207,9 +207,12 @@
   char **default_argv;
   MY_INIT(argv[0]);
 
-  if (load_defaults("my",load_default_groups,&argc,&argv))
+  if (load_defaults("my",load_default_groups,&argc,&argv) ||
+      mi_init_open_table_hash(0))
+  {
+    fputs("Can't initialize MyISAM storage engine", stderr);
     exit(1);
-
+  }
   default_argv= argv;
   get_options(&argc,&argv);