Code review comment for lp:~vlad-lesin/percona-server/5.1-bug1049871-injections-gca

Vlad Lesin (vlad-lesin) wrote :

> - QUOTED_IDENTIFIED macro definition should use the do { ... }
> while(0) idiom.
The idea of this macros is to use allocation on stack for string operation. That is why that idiom does not suite for the macros.

> Also, it is duplicated three times in the patch.
IMHO the macros is repeated twice as the whole sql_string.* for client and server parts. Logically this macros should be in sql_string.h header. I decided it is not a good idea to make new header file just for that macros.

> - Lines 1074--1075 formatting issue.
Fixed.

> - The patch is missing
> mysql-test/suite/rpl/t/rpl_mdev382.test|result. Is this intentional?
I missed it. Thanks. I relaunched jenkins testing to be sure this test is passed.

« Back to merge proposal