PBXT

Merge lp:~vkolesnikov/pbxt/pbxt-bug-315564 into lp:pbxt

  1. pbxt-bug-315564
  2. Merge into trunk
Proposed by Vladimir Kolesnikov
Status: Merged
Merged at revision: not available
Proposed branch: lp:~vkolesnikov/pbxt/pbxt-bug-315564
Merge into: lp:pbxt
To merge this branch: bzr merge lp:~vkolesnikov/pbxt/pbxt-bug-315564
Reviewer Review Type Date Requested Status
PBXT Core Pending
Review via email: mp+3221@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Vladimir Kolesnikov (vkolesnikov) wrote :

tested on linux & win32

lp:~vkolesnikov/pbxt/pbxt-bug-315564 updated
535. By Paul McCullagh

Merged RN217 which fixed bug #315564

Revision history for this message
Paul McCullagh (paul-mccullagh) wrote :

Hi Vlad,

I have pushed this bug fix with a few minor changes.

Firstly, we cannot use *op_seq returns 0 as an indicator that the function did nothing, because 0 is a valid op ID! The op ID can go to zero when the 4 byte ID overflows.

I have also change the name of the function from xt_tc_write_bor() to xt_tc_write_cond(). The reason is because it no longer does a bit-wise OR. This is no longer necessary. We now only update if the type byte in the header if it exactly matches the value in the log.

I also added a comment explaining the reason for the change.

Subscribers

People subscribed via source and target branches