Code review comment for lp:~vkolesnikov/maria/maria-pbxt-bug-439889

Revision history for this message
Kristian Nielsen (knielsen) wrote :

Looks good, thanks!

I suggest some changes, mainly to make the mysql-test-run --embedded test
suite work. I pushed these changes to a branch on Launchpad, please check them
out and see what you think:

    lp:~knielsen/maria/mariadb-pbxt-mbug439889

1. In embedded server, max_connections is set to 1. This causes problems since
   PBXT uses max_connections to create a default value for pbxt_max_threads. I
   suggest a small hack in the above branch to solve this case, but lets
   discuss if you have a better suggestion.

2. I changed a number of printf(...) in PBXT to fprintf(stderr,
   ...). Otherwise the output of mysql-test-run --embedded gets flooded with
   lots ouf PBXT output. It seems to me better in any case to use stderr for
   this, but again let me know if you have a better suggestion.

3. Update some .test and .result files for --embedded (two tests I disabled in
   --embedded due to SHOW PROCESSLIST and mysqldump usage).

4. I moved mysql-test/suite/pbxt/t/load_unique_error1.inc into
   mysql-test/std_data/, to make it usable in both normal and embedded tests
   (it seems embedded tests run with a different current directory). Do you
   think that is ok?

If you think these changes look ok (or have better suggestions), I will merge
them into MariaDB.

review: Approve

« Back to merge proposal