Merge lp:~vjsamuel/drizzle/fix-bug-632589 into lp:~drizzle-trunk/drizzle/development

Proposed by Vijay Samuel
Status: Merged
Approved by: Brian Aker
Approved revision: 1750
Merged at revision: 1753
Proposed branch: lp:~vjsamuel/drizzle/fix-bug-632589
Merge into: lp:~drizzle-trunk/drizzle/development
Diff against target: 112 lines (+17/-17)
7 files modified
plugin/embedded_innodb/embedded_innodb_engine.cc (+11/-11)
plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_adaptive_flushing_on-master.opt (+1/-1)
plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_adaptive_hash_index_on-master.opt (+1/-1)
plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_file_per_table_enable-master.opt (+1/-1)
plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_print_verbose_log_on-master.opt (+1/-1)
plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_rollback_on_timeout_on-master.opt (+1/-1)
plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_use_sys_malloc_on-master.opt (+1/-1)
To merge this branch: bzr merge lp:~vjsamuel/drizzle/fix-bug-632589
Reviewer Review Type Date Requested Status
Drizzle Merge Team Pending
Review via email: mp+34875@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugin/embedded_innodb/embedded_innodb_engine.cc'
2--- plugin/embedded_innodb/embedded_innodb_engine.cc 2010-08-17 03:04:15 +0000
3+++ plugin/embedded_innodb/embedded_innodb_engine.cc 2010-09-08 16:27:45 +0000
4@@ -3435,10 +3435,10 @@
5 static void init_options(drizzled::module::option_context &context)
6 {
7 context("adaptive-hash-index",
8- po::value<bool>(&innobase_adaptive_hash_index)->default_value(true),
9+ po::value<bool>(&innobase_adaptive_hash_index)->default_value(true)->zero_tokens()->multitoken(),
10 N_("Enable InnoDB adaptive hash index (enabled by default)."));
11 context("adaptive-flushing",
12- po::value<bool>(&srv_adaptive_flushing)->default_value(true),
13+ po::value<bool>(&srv_adaptive_flushing)->default_value(true)->zero_tokens()->multitoken(),
14 N_("Attempt flushing dirty pages to avoid IO bursts at checkpoints."));
15 context("additional-mem-pool-size",
16 po::value<long>(&innobase_additional_mem_pool_size)->default_value(8*1024*1024L),
17@@ -3453,11 +3453,11 @@
18 po::value<string>(),
19 N_("The common part for InnoDB table spaces."));
20 context("checksums",
21- po::value<bool>(&innobase_use_checksums)->default_value(true),
22- N_("Enable InnoDB checksums validation (enabled by default). Disable with --skip-innodb-checksums."));
23+ po::value<bool>(&innobase_use_checksums)->default_value(true)->zero_tokens()->multitoken(),
24+ N_("Enable InnoDB checksums validation (enabled by default)."));
25 context("doublewrite",
26- po::value<bool>(&innobase_use_doublewrite)->default_value(true),
27- N_("Enable InnoDB doublewrite buffer (enabled by default). Disable with --skip-innodb-doublewrite."));
28+ po::value<bool>(&innobase_use_doublewrite)->default_value(true)->zero_tokens()->multitoken(),
29+ N_("Enable InnoDB doublewrite buffer (enabled by default)."));
30 context("io-capacity",
31 po::value<unsigned long>(&srv_io_capacity)->default_value(200),
32 N_("Number of IOPs the server can do. Tunes the background IO rate"));
33@@ -3465,7 +3465,7 @@
34 po::value<unsigned long>(&innobase_fast_shutdown)->default_value(1),
35 N_("Speeds up the shutdown process of the InnoDB storage engine. Possible values are 0, 1 (faster) or 2 (fastest - crash-like)."));
36 context("file-per-table",
37- po::value<bool>(&srv_file_per_table)->default_value(false),
38+ po::value<bool>(&srv_file_per_table)->default_value(false)->zero_tokens()->multitoken(),
39 N_("Stores each InnoDB table to an .ibd file in the database dir."));
40 context("file-format",
41 po::value<string>(),
42@@ -3513,7 +3513,7 @@
43 po::value<unsigned long>(&srv_max_purge_lag)->default_value(0),
44 N_("Desired maximum length of the purge queue (0 = no limit)"));
45 context("rollback-on-timeout",
46- po::value<bool>(&innobase_rollback_on_timeout)->default_value(false),
47+ po::value<bool>(&innobase_rollback_on_timeout)->default_value(false)->zero_tokens()->multitoken(),
48 N_("Roll back the complete transaction on lock wait timeout, for 4.x compatibility (disabled by default)"));
49 context("open-files",
50 po::value<long>(&innobase_open_files)->default_value(300),
51@@ -3525,16 +3525,16 @@
52 po::value<unsigned long>(&innobase_write_io_threads)->default_value(4),
53 N_("Number of background write I/O threads in InnoDB."));
54 context("print-verbose-log",
55- po::value<bool>(&innobase_print_verbose_log)->default_value(true),
56+ po::value<bool>(&innobase_print_verbose_log)->default_value(true)->zero_tokens()->multitoken(),
57 N_("Disable if you want to reduce the number of messages written to the log (default: enabled)."));
58 context("status-file",
59- po::value<bool>(&innobase_create_status_file)->default_value(false),
60+ po::value<bool>(&innobase_create_status_file)->default_value(false)->zero_tokens()->multitoken(),
61 N_("Enable SHOW INNODB STATUS output in the log"));
62 context("sync-spin-loops",
63 po::value<unsigned long>(&srv_n_spin_wait_rounds)->default_value(30L),
64 N_("Count of spin-loop rounds in InnoDB mutexes (30 by default)"));
65 context("use-sys-malloc",
66- po::value<bool>(&srv_use_sys_malloc)->default_value(true),
67+ po::value<bool>(&srv_use_sys_malloc)->default_value(true)->zero_tokens()->multitoken(),
68 N_("Use OS memory allocator instead of InnoDB's internal memory allocator"));
69 }
70
71
72=== modified file 'plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_adaptive_flushing_on-master.opt'
73--- plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_adaptive_flushing_on-master.opt 2010-08-19 18:07:50 +0000
74+++ plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_adaptive_flushing_on-master.opt 2010-09-08 16:27:45 +0000
75@@ -1,1 +1,1 @@
76---plugin-add=embedded_innodb --plugin-remove=innobase --innodb.adaptive-flushing=true
77+--plugin-add=embedded_innodb --plugin-remove=innobase --innodb.adaptive-flushing
78
79=== modified file 'plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_adaptive_hash_index_on-master.opt'
80--- plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_adaptive_hash_index_on-master.opt 2010-08-19 18:07:50 +0000
81+++ plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_adaptive_hash_index_on-master.opt 2010-09-08 16:27:45 +0000
82@@ -1,1 +1,1 @@
83---plugin-add=embedded_innodb --plugin-remove=innobase --innodb.adaptive-hash-index=true
84+--plugin-add=embedded_innodb --plugin-remove=innobase --innodb.adaptive-hash-index
85
86=== modified file 'plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_file_per_table_enable-master.opt'
87--- plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_file_per_table_enable-master.opt 2010-08-19 18:07:50 +0000
88+++ plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_file_per_table_enable-master.opt 2010-09-08 16:27:45 +0000
89@@ -1,1 +1,1 @@
90---plugin-add=embedded_innodb --plugin-remove=innobase --innodb.file-per-table=true
91+--plugin-add=embedded_innodb --plugin-remove=innobase --innodb.file-per-table
92
93=== modified file 'plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_print_verbose_log_on-master.opt'
94--- plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_print_verbose_log_on-master.opt 2010-08-19 18:07:50 +0000
95+++ plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_print_verbose_log_on-master.opt 2010-09-08 16:27:45 +0000
96@@ -1,1 +1,1 @@
97---plugin-add=embedded_innodb --plugin-remove=innobase --innodb.print-verbose-log=true
98+--plugin-add=embedded_innodb --plugin-remove=innobase --innodb.print-verbose-log
99
100=== modified file 'plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_rollback_on_timeout_on-master.opt'
101--- plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_rollback_on_timeout_on-master.opt 2010-08-19 18:07:50 +0000
102+++ plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_rollback_on_timeout_on-master.opt 2010-09-08 16:27:45 +0000
103@@ -1,1 +1,1 @@
104---plugin-add=embedded_innodb --plugin-remove=innobase --innodb.rollback-on-timeout=1
105+--plugin-add=embedded_innodb --plugin-remove=innobase --innodb.rollback-on-timeout
106
107=== modified file 'plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_use_sys_malloc_on-master.opt'
108--- plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_use_sys_malloc_on-master.opt 2010-08-19 18:07:50 +0000
109+++ plugin/embedded_innodb/test-suite-dir/embedded_innodb/tests/t/config_use_sys_malloc_on-master.opt 2010-09-08 16:27:45 +0000
110@@ -1,1 +1,1 @@
111---plugin-add=embedded_innodb --plugin-remove=innobase --innodb.use-sys-malloc=1
112+--plugin-add=embedded_innodb --plugin-remove=innobase --innodb.use-sys-malloc