IPython - Enhanced Interactive Python

Merge lp:~vivian-vdesmedt/ipython/synchronize-editor into lp:ipython/0.11

Proposed by Fernando Perez on 2008-08-08
Status: Merged
Merge reported by: Fernando Perez
Merged at revision: 1101
Proposed branch: lp:~vivian-vdesmedt/ipython/synchronize-editor
Merge into: lp:ipython/0.11
To merge this branch: bzr merge lp:~vivian-vdesmedt/ipython/synchronize-editor
To post a comment you must log in.
1075. By Fernando Perez on 2008-08-08

Merge with upstream

1076. By Fernando Perez on 2008-08-08

Adjust regexps for random tests

Fernando Perez (fdo.perez) wrote :

Mmh, I was getting ready to merge and push, but then I went and looked at the code, and I see the whole thing is written in camelCase():

http://bazaar.launchpad.net/%7Evivian-vdesmedt/ipython/synchronize-editor/annotate/1007?file_id=ipy_synchronize_with-20080612032938-lxufpyi2plzu3mlc-1

Why is that the case? For all new code, we are really trying to stick to proper PEP-8 within reason, and I don't want to violate that unless there's a good motive for it.

I also don't see any docstrings in any of the functions at all.

Vivian, I realize that this may be a bit painful, but as you can see, we're now making an honest effort at building a much higher quality codebase for IPython, so that all code that goes in is reviewed, documented and tested. And we are all living by the same rules (see recent reviews on other branches, and all the work that has gone into having testing machinery for ipython itself).

With bzr and launchpad, it's relatively easy for you to track the trunk (simply keep merging from trunk into your working branch and pushing back upstream frequently), so that your branch stays up to date, as you improve it. But I really think that we can't merge this code in until it's properly documented and it matches the naming conventions of the rest of the project.

I realize it's a bit frustrating at this point, but hopefully it's clear to you that these rules are there to ensure that as the whole project grows in a very healthy fashion. We're getting more new code coming in than any one of us can handle individually, and the only way we won't crumble under the weight is to enforce that all this new code is compliant with the rest of the project, documented and automatically tested.

1077. By Fernando Perez on 2008-08-12

Checkpoint before merging with upstream

1078. By Fernando Perez on 2008-08-12

Merge with upstream

1079. By Fernando Perez on 2008-08-12

Use updated user namespace construction API

1080. By Fernando Perez on 2008-08-13

Merge with upstream

1081. By Fernando Perez on 2008-08-13

Merge with upstream

1082. By Fernando Perez on 2008-08-14

Merge with upstream

1083. By Fernando Perez on 2008-08-14

Disable debug message

1084. By Fernando Perez on 2008-08-14

Correctly implement namespace handling. Minor cleanups.

Finally found a solution to manage the namespace where doctests are
run in conjunction with the IPython one. All tests seem to pass now
(except for an intermittent failure in one Twisted one that looks like
a race condition somewhere, since it doesn't always appear).

1085. By Fernando Perez on 2008-08-14

Reactivate completion test now that namespaces are working

1086. By Fernando Perez on 2008-08-14

Rename two tests that had identical names to distinguish them.

One of these (testExecuteFailuresEngineService_0) fails often, though
not always. I spent hours trying to debug what's going on but failed,
and it's non-deterministic.

1087. By Ville M. Vainio on 2008-08-14

ILeo: comment out format_for_leo for list (bad idea!)

1088. By Ville M. Vainio on 2008-08-14

LeoNode.last_edited

1089. By Ville M. Vainio on 2008-08-14

ILeo: LeoNode.__delitem__ and append(). Now clear() etc work

1090. By Ville M. Vainio on 2008-08-14

cd -foo jumps to dir matching 'foo' in directory history

1091. By Ville M. Vainio on 2008-08-14

use cd --foo instead of cd -foo. also cd --<TAB> works. changes.txt

1092. By Ville M. Vainio on 2008-08-14

ileo: wb.require() for handling inter-node dependencies

1093. By Ville M. Vainio on 2008-08-14

ileo: _p does not get erased with recursive ipush / wb.require()

1094. By Ville M. Vainio on 2008-08-15

ileo: call outerUpdate to update leo outline in pre_prompt_hook

1095. By Fernando Perez on 2008-08-15

Fixes to build system.

1096. By Fernando Perez on 2008-08-15

Merge with upstream

1097. By Fernando Perez on 2008-08-15

Little test file for plugin

1098. By Fernando Perez on 2008-08-15

Fixes to build/setup machinery.

Lots of changes to setup.py and doc building machinery to ensure we
get all the docs correctly built and installed at the end.

1099. By Fernando Perez on 2008-08-15

update revnum

1100. By Fernando Perez on 2008-08-15

Small updates to build tools (rpm building temporarily off)

1101. By Fernando Perez on 2008-08-15

List Ville Vainio as doc author.

Subscribers

People subscribed via source and target branches