Merge lp:~vishvananda/nova/vnc_console into lp:~hudson-openstack/nova/trunk

Proposed by Vish Ishaya
Status: Merged
Approved by: Josh Kearney
Approved revision: 788
Merged at revision: 938
Proposed branch: lp:~vishvananda/nova/vnc_console
Merge into: lp:~hudson-openstack/nova/trunk
Diff against target: 17 lines (+5/-1)
1 file modified
nova/compute/api.py (+5/-1)
To merge this branch: bzr merge lp:~vishvananda/nova/vnc_console
Reviewer Review Type Date Requested Status
Josh Kearney (community) Approve
termie (community) Needs Fixing
Devin Carlen (community) Approve
Jesse Andrews (community) Approve
Review via email: mp+55471@code.launchpad.net

Commit message

Declares the flag for vncproxy_topic in compute.api

Description of the change

Fixes the localization strings in the vnc_console branch so we can merge it. Branch was already approved at https://code.launchpad.net/~sleepsonthefloor/nova/vnc_console/+merge/54805
, but had a couple bad localization strings.

To post a comment you must log in.
Revision history for this message
Jesse Andrews (anotherjesse) wrote :

lgtm

review: Approve
Revision history for this message
Vish Ishaya (vishvananda) wrote :

sending this to hudson since it was already approved minus the localization fix.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Revision history for this message
Vish Ishaya (vishvananda) wrote :

there was a little bug. reproposing

Revision history for this message
Devin Carlen (devcamcar) wrote :

lgtm

review: Approve
Revision history for this message
termie (termie) wrote :

move to be next to the flags part instead of having a LOG inbetween?

review: Needs Fixing
Revision history for this message
Vish Ishaya (vishvananda) wrote :

fixed spacing and ordering

lp:~vishvananda/nova/vnc_console updated
788. By Vish Ishaya

fixed ordering and spacing

Revision history for this message
Josh Kearney (jk0) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'nova/compute/api.py'
2--- nova/compute/api.py 2011-03-30 05:59:13 +0000
3+++ nova/compute/api.py 2011-03-30 19:51:01 +0000
4@@ -37,8 +37,12 @@
5 from nova.scheduler import api as scheduler_api
6 from nova.db import base
7
8+
9+LOG = logging.getLogger('nova.compute.api')
10+
11+
12 FLAGS = flags.FLAGS
13-LOG = logging.getLogger('nova.compute.api')
14+flags.DECLARE('vncproxy_topic', 'nova.vnc')
15
16
17 def generate_default_hostname(instance_id):