Merge lp:~vishvananda/nova/lp814471 into lp:~hudson-openstack/nova/trunk

Proposed by Vish Ishaya
Status: Merged
Approved by: Brian Lamar
Approved revision: 1305
Merged at revision: 1307
Proposed branch: lp:~vishvananda/nova/lp814471
Merge into: lp:~hudson-openstack/nova/trunk
Diff against target: 19 lines (+1/-1)
1 file modified
nova/network/manager.py (+1/-1)
To merge this branch: bzr merge lp:~vishvananda/nova/lp814471
Reviewer Review Type Date Requested Status
Brian Lamar (community) Approve
Brian Waldon (community) Approve
Review via email: mp+68923@code.launchpad.net

Description of the change

Fixes an issue with out of order operations in setup_network for vlan mode in new ha-net code.

To post a comment you must log in.
Revision history for this message
Brian Waldon (bcwaldon) wrote :

Approved.

review: Approve
Revision history for this message
Brian Lamar (blamar) wrote :

Approved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'nova/network/manager.py'
2--- nova/network/manager.py 2011-07-22 21:48:04 +0000
3+++ nova/network/manager.py 2011-07-22 22:43:58 +0000
4@@ -898,7 +898,6 @@
5
6 def _setup_network(self, context, network_ref):
7 """Sets up network on this host."""
8- network_ref['dhcp_server'] = self._get_dhcp_ip(context, network_ref)
9 if not network_ref['vpn_public_address']:
10 net = {}
11 address = FLAGS.vpn_ip
12@@ -906,6 +905,7 @@
13 network_ref = db.network_update(context, network_ref['id'], net)
14 else:
15 address = network_ref['vpn_public_address']
16+ network_ref['dhcp_server'] = self._get_dhcp_ip(context, network_ref)
17 self.driver.ensure_vlan_bridge(network_ref['vlan'],
18 network_ref['bridge'],
19 network_ref['bridge_interface'],