Merge lp:~vishvananda/nova/lp711948 into lp:~hudson-openstack/nova/trunk

Proposed by Vish Ishaya
Status: Merged
Approved by: Soren Hansen
Approved revision: 646
Merged at revision: 658
Proposed branch: lp:~vishvananda/nova/lp711948
Merge into: lp:~hudson-openstack/nova/trunk
Diff against target: 30 lines (+4/-2)
1 file modified
nova/network/manager.py (+4/-2)
To merge this branch: bzr merge lp:~vishvananda/nova/lp711948
Reviewer Review Type Date Requested Status
Soren Hansen (community) Approve
Devin Carlen (community) Approve
Thierry Carrez (community) Approve
Review via email: mp+48335@code.launchpad.net

Description of the change

Fixes the ordering of init_host commands so that iptables chains are created before they are used.

This fixes an issue that arises if nova-network is started with flushed iptables after floating ips have been assigned.

To post a comment you must log in.
Revision history for this message
Devin Carlen (devcamcar) wrote :

lgtm

review: Approve
Revision history for this message
Thierry Carrez (ttx) wrote :

Too late for Bexar, please submit in Cactus.

review: Needs Resubmitting (rcfe)
Revision history for this message
Thierry Carrez (ttx) wrote :

lgtm

review: Approve
Revision history for this message
Vish Ishaya (vishvananda) wrote :

I think this proposal got lost through the release. It could use a little love.

Revision history for this message
Devin Carlen (devcamcar) wrote :

re-loved

review: Approve
Revision history for this message
Soren Hansen (soren) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'nova/network/manager.py'
2--- nova/network/manager.py 2011-01-26 21:58:24 +0000
3+++ nova/network/manager.py 2011-02-02 16:20:24 +0000
4@@ -118,6 +118,10 @@
5 super(NetworkManager, self).__init__(*args, **kwargs)
6
7 def init_host(self):
8+ """Do any initialization that needs to be run if this is a
9+ standalone service.
10+ """
11+ self.driver.init_host()
12 # Set up networking for the projects for which we're already
13 # the designated network host.
14 ctxt = context.get_admin_context()
15@@ -395,7 +399,6 @@
16 standalone service.
17 """
18 super(FlatDHCPManager, self).init_host()
19- self.driver.init_host()
20 self.driver.metadata_forward()
21
22 def setup_compute_network(self, context, instance_id):
23@@ -465,7 +468,6 @@
24 standalone service.
25 """
26 super(VlanManager, self).init_host()
27- self.driver.init_host()
28 self.driver.metadata_forward()
29
30 def allocate_fixed_ip(self, context, instance_id, *args, **kwargs):