lp:~vishvananda/glance/fix-update

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~glance-coresec/glance/cactus-trunk at revision 80

Jay Pipes (community): Approve on 2011-03-05

Devin Carlen (community): Approve on 2011-03-04

Diff: 130 lines (+62/-11)

4 files modified

glance/client.py (+11/-7)
glance/utils.py (+8/-3)
tests/unit/test_api.py (+1/-1)
tests/unit/test_misc.py (+42/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #728861: client.update_image is broken

Undecided

Fix Released

Link a bug report

Related blueprints

80. By Vish Ishaya on 2011-03-05

remove test skip

79. By Rick Harris on 2011-03-01

Work around Eventlet exception clearing by memorizing exception context and re-raising using 3-arg form.

78. By Rick Harris on 2011-03-01

Reverts Image `type` back to the old behavior of being nullable.

Necessary because Nova creates Glance image records without knowing which `type` they will be up-front.

77. By Soren Hansen on 2011-02-28

Add sys.path mangling to glance-upload.

76. By Rick Harris on 2011-02-25

Makes --kernel and --ramdisk required arguments for glance-upload since Nova currently requires them.

The `null_kernel` concept in Nova is slated to be removed, so this is really just a stop gap measure.

75. By Jay Pipes on 2011-02-23

This adds a test case for LP Bug 704854 -- Exception
raised by Registry server gets eaten by API server.

The test involves spinning up an API server and a registry
server, firing cURL and glance-upload against the API
server with invalid requests, and verifying that appropriate
exception messages are contained in the response.

I should probably rebase this commit considering all the previous
commits weren't actually addressing the issue. The fact that I
had glance-api and glance-registry installed on my local machine
was causing the test runs to improperly return a passing result.

It just so happens that the glance-api and glance-registry that
I had installed to my /usr/local/bin were the very same programs
that were from a previous branch I had locally where I fixed the
root cause of this issue, which was that the sqlalchemy @validates
decorator does NOT fire for *new* objects, only existing ones, which
resulted in image_create() improperly storing NULL data in type, name,
and other non-nullable fields in the database. This then set off
a domino effect which caused the next call from
glance.server._upload_and_activate() to die a horrible death due to
the @validates decorator then firing on the already-created Image
object. This horrible death was improperly being raised from the
glance.client as a BadRequest instead of exception.Invalid, which
caused the API server to ignore the text in the actual Invalid
exception coming from the registry server.

In short, this patch finally fixes the root of the problem by
placing a validate_image() function guard which throws exception.Invalid
for any invalid data coming into the _image_update() method in the db
API. It also adds a bunch of logging statements and ensures that
exceptions throughout the call stack between the API server to the
glance.registry.Client to the Registry server are properly handled and
that the text of those exceptions isn't thrown away willy-nilly.

74. By Rick Harris on 2011-02-17

Removes image type validation in the Glance registry.

Nova xs-unified-images requires adding a new image type 'vhd' along side of 'machine', 'raw', etc. Since image_type isn't used by Glance itself (it merely stores the value and hands it back to Nova), Glance shouldn't be the arbiter of what values are acceptable-- Nova should. This promotes loose-coupling and ensures that Glance won't have to change in lock-step with Nova.

More to the point, this a stop-gap to make Glance work with the new xs-unified-images branch until we get proper `container_format` and `disk_format` modeling in Glance. When that happens, we may end up ditching `image_type` altogether.

73. By Jay Pipes on 2011-02-16

Adds --pid-file option to bin/glance-control

72. By Jay Pipes on 2011-02-16

Adds Location: header to return from API server for POST /images, per APP spec

71. By Jay Pipes on 2011-02-16

Add an ImportError check when importing migrate.exceptions, as the location of that module changed in a recent version of the sqlalchemy-migrate library.