Merge lp:~vishalbhoj/linaro-android-build-tools/Add-lava-imgs-support-Fix-homescreen into lp:linaro-android-build-tools

Proposed by vishal
Status: Merged
Merged at revision: 618
Proposed branch: lp:~vishalbhoj/linaro-android-build-tools/Add-lava-imgs-support-Fix-homescreen
Merge into: lp:linaro-android-build-tools
Diff against target: 45 lines (+14/-7)
1 file modified
build-scripts/post-build-lava.py (+14/-7)
To merge this branch: bzr merge lp:~vishalbhoj/linaro-android-build-tools/Add-lava-imgs-support-Fix-homescreen
Reviewer Review Type Date Requested Status
Paul Sokolovsky Approve
Review via email: mp+165546@code.launchpad.net

Description of the change

The job was submitted to LAVA. The branch is tested in this job:
https://android-build.linaro.org/builds/~vishalbhoj/nexus-job-test/

To post a comment you must log in.
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Sorry for nitpicking, but please make sure there's a space after comma in "/userdata.",file_extension .

620. By vishal

cleanup coding style

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'build-scripts/post-build-lava.py'
2--- build-scripts/post-build-lava.py 2013-05-22 18:52:05 +0000
3+++ build-scripts/post-build-lava.py 2013-05-24 07:55:31 +0000
4@@ -361,6 +361,13 @@
5 # if this value is not set, then use the 18000 seconds as the default value
6 default_timeout = os.environ.get("DEFAULT_TIMEOUT", 18000)
7
8+ # Set the file extension based on the type of artifacts
9+ artifact_type = os.environ.get("MAKE_TARGETS", "tarball")
10+ if artifact_type == "droidcore":
11+ file_extension = "img"
12+ else:
13+ file_extension = "tar.bz2"
14+
15 # Board-specific parameters
16 if target_product not in PRODUCT_MAP:
17 # We don't know how to test this job, so skip testing.
18@@ -394,12 +401,12 @@
19 "command": "deploy_linaro_android_image",
20 "parameters":
21 {
22- "boot": "%s%s" % (download_url,
23- "/boot.tar.bz2"),
24- "system":"%s%s" % (download_url,
25- "/system.tar.bz2"),
26- "data":"%s%s" % (download_url,
27- "/userdata.tar.bz2")
28+ "boot": "%s%s%s" % (download_url,
29+ "/boot.", file_extension),
30+ "system":"%s%s%s" % (download_url,
31+ "/system.", file_extension),
32+ "data":"%s%s%s" % (download_url,
33+ "/userdata.", file_extension)
34 },
35 "metadata":
36 {
37@@ -415,7 +422,7 @@
38 if wait_for_homescreen == False:
39 common_actions.append({"command": "boot_linaro_android_image",
40 "parameters": {
41- "wait_for_home_screen": "false"
42+ "wait_for_home_screen": False
43 }
44 })
45 else:

Subscribers

People subscribed via source and target branches