Merge lp:~vish/gwibber/pressedbutton into lp:gwibber

Proposed by Vish
Status: Merged
Merge reported by: Ryan Paul
Merged at revision: not available
Proposed branch: lp:~vish/gwibber/pressedbutton
Merge into: lp:gwibber
Diff against target: 25 lines (+2/-2)
2 files modified
ui/templates/navigation.mako (+1/-1)
ui/templates/targetbar.mako (+1/-1)
To merge this branch: bzr merge lp:~vish/gwibber/pressedbutton
Reviewer Review Type Date Requested Status
gwibber-committers Pending
Review via email: mp+18774@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Vish (vish) wrote :

Gwibber ,in trunk, has a new style for the buttons. The buttons appear as shiny projections when activated[pressed].

This is a deviation from the system-wide behavior and not the expected behavior the user would expect from "pressing" a button.

There is another problem , since the shine is behind the icon , the shine doesnt fall on the icon , making the icon look not part of the button.

For a screenshot of the change , pls see > https://bugs.launchpad.net/gwibber/+bug/518191

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ui/templates/navigation.mako'
2--- ui/templates/navigation.mako 2010-02-06 07:19:09 +0000
3+++ ui/templates/navigation.mako 2010-02-06 21:28:15 +0000
4@@ -19,7 +19,7 @@
5 </%def>
6
7 <%def name="shine()" filter="trim">
8- -webkit-gradient(linear, left top, left bottom, from(rgba(255, 255, 255, 0.45)), to(rgba(255, 255, 255, 0.50)), color-stop(0.4, rgba(255, 255, 255, 0.25)), color-stop(0.6, rgba(255, 255, 255, 0.0)), color-stop(0.9, rgba(255, 255, 255, 0.10)))
9+ -webkit-gradient(linear, left top, left bottom, from(rgba(0, 0, 0, 0.45)), to(rgba(255, 255, 255, 0.42)), color-stop(0.4, rgba(0, 0, 0, 0.15)), color-stop(0.6, rgba(0, 0, 0, 0.0)), color-stop(0.9, rgba(255, 255, 255, 0.06)))
10 </%def>
11
12 <%def name="accountcss(account)" filter="trim">
13
14=== modified file 'ui/templates/targetbar.mako'
15--- ui/templates/targetbar.mako 2010-02-06 07:19:09 +0000
16+++ ui/templates/targetbar.mako 2010-02-06 21:28:15 +0000
17@@ -10,7 +10,7 @@
18 %>
19
20 <%def name="shine()" filter="trim">
21- -webkit-gradient(linear, left top, left bottom, from(rgba(255, 255, 255, 0.45)), to(rgba(255, 255, 255, 0.50)), color-stop(0.4, rgba(255, 255, 255, 0.25)), color-stop(0.6, rgba(255, 255, 255, 0.0)), color-stop(0.9, rgba(255, 255, 255, 0.10)))
22+ -webkit-gradient(linear, left top, left bottom, from(rgba(0, 0, 0, 0.45)), to(rgba(255, 255, 255, 0.42)), color-stop(0.4, rgba(0, 0, 0, 0.15)), color-stop(0.6, rgba(0, 0, 0, 0.0)), color-stop(0.9, rgba(255, 255, 255, 0.06)))
23 </%def>
24
25 <%def name="user(target)" buffered="True">

Subscribers

People subscribed via source and target branches