Code review comment for lp:~villemvainio/ipython/trunk-dev
Revision history for this message
| Ville M. Vainio (villemvainio) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
I addressed the missing comments (1155, 1156). I also reverted 1159 (it doesn't make sense, IMO, to add a micro-test for this particular completer - it should be a part of proper completer test suite that tests the whole interactive completion chain).
r1160 - I'm hesitant to do full-blown exception display for this scenario, because it deals with ctrl+c and gthread (it's always a trivial IOError, I think). This will never display an exception that is of any use for the user, and it makes sense to mimize the stuff we run in these corner cases
Apart from that, it should be safe for merging now.