Merge lp:~vila/uci-engine/britney-process-reports into lp:uci-engine

[Vincent Ladeuil]

Process britney test result reports.

This is the last bit of the britney-proxy which can be used on jenkins or to validate the migration (among other tools).

It includes some slight refactoring to share more code but really build on
top of the previous parts, the "real" work is done in
britney_proxy/britney/process_reports.py BritneyReportHandler.handle().

Followups MPs will factorize the relevant pieces so a new service can be implemented with less paperwork ;)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:908
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1652/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1652/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:909
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1653/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1653/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:912
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1654/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1654/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:914
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1655/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1655/rebuild

review: Approve (continuous-integration)

[Vincent Ladeuil (vila)]

What this MP provides may be clearer when looking at its output (sample from a live run):

2014-10-31 00:53:23,951 INFO trusty amd64 zope.interface
2014-10-31 00:53:24,741 INFO utopic amd64 abi-compliance-checker
2014-10-31 00:53:48,177 INFO trusty amd64 zope.testing
2014-10-31 00:54:18,008 INFO trusty amd64 zope.session
2014-10-31 00:54:31,651 INFO trusty amd64 zope.testrunner
2014-10-31 00:54:32,796 INFO trusty amd64 zope.formlib
2014-10-31 00:55:37,291 INFO utopic amd64 adduser
2014-10-31 00:55:59,448 INFO utopic amd64 alglib
2014-10-31 00:56:00,395 INFO utopic amd64 apache2
2014-10-31 00:56:25,780 INFO utopic amd64 apparmor-easyprof-ubuntu
2014-10-31 00:56:42,962 INFO utopic amd64 appstream
2014-10-31 00:56:55,261 INFO utopic amd64 apq-postgresql
2014-10-31 00:57:32,190 INFO utopic amd64 adequate

Measures included ;)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:915
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1656/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1656/rebuild

review: Approve (continuous-integration)

[Martin Pitt (pitti)]

I have some nitpicks and a question below. In general I'm still unsure why we need a "britney report/result queue". We will *not* listen to a queue in britney, that just doesn't conceptually work. We want to poll a results tree (like trusty/amd64/libp/libpng/yymmdd_hhmmss/) from swift, rsync, or similar (i. e. a network file system); preferably swift as that's where we write the results to, and we should not unnecessarily put extra stuff in between which can again fail :-)

[Vincent Ladeuil (vila)]

> I have some nitpicks and a question below. In general I'm still unsure why we
> need a "britney report/result queue". We will *not* listen to a queue in
> britney, that just doesn't conceptually work. We want to poll a results tree
> (like trusty/amd64/libp/libpng/yymmdd_hhmmss/) from swift, rsync, or similar
> (i. e. a network file system); preferably swift as that's where we write the
> results to, and we should not unnecessarily put extra stuff in between which
> can again fail :-)

Yup, that's what I want to reach asap without blocking the validation which can progress with this MP.

[Vincent Ladeuil (vila)]

Grr, lp didn't save the comments in the previous reply

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:916
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1658/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1658/rebuild

review: Approve (continuous-integration)

[Francis Ginther (fginther)]

Just a few questions and a typo. Otherwise looks good.

review: Needs Fixing

[Vincent Ladeuil (vila)]

All fixed, replies inline.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:918
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1660/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1660/rebuild

review: Approve (continuous-integration)

[Francis Ginther (fginther)]

Approve.

review: Approve

[Ubuntu CI Bot (uci-bot)]

The attempt to merge lp:~vila/uci-engine/britney-process-reports into lp:uci-engine failed. Below is the output from the failed tests.

Running cm...
Updating source dependencies...
Updating source dependencies...
Updating source dependencies...
Updating source dependencies...
Updating source dependencies...
Updating source dependencies...
uploading webui-content.tgz to swift
Updating source dependencies...
2014-11-01 10:48:20 INFO juju.cmd supercommand.go:37 running jujud [1.20.11.1-precise-amd64 gc]
2014-11-01 10:48:20 DEBUG juju.agent agent.go:377 read agent config, format "1.18"
2014-11-01 10:48:20 INFO juju.jujud unit.go:78 unit agent unit-ci-airline-ts-django-0 start (1.20.11.1-precise-amd64 [gc])
2014-11-01 10:48:20 INFO juju.worker runner.go:260 start "api"
2014-11-01 10:48:20 INFO juju.state.api apiclient.go:242 dialing "wss://10.0.3.1:17070/"
2014-11-01 10:48:20 INFO juju.state.api apiclient.go:176 connection established to "wss://10.0.3.1:17070/"
2014-11-01 10:48:20 INFO juju.state.api apiclient.go:242 dialing "wss://10.0.3.1:17070/"
2014-11-01 10:48:20 INFO juju.state.api apiclient.go:176 connection established to "wss://10.0.3.1:17070/"
2014-11-01 10:48:21 INFO juju.state.api apiclient.go:242 dialing "wss://10.0.3.1:17070/"
2014-11-01 10:48:21 INFO juju.state.api apiclient.go:176 connection established to "wss://10.0.3.1:17070/"
2014-11-01 10:48:22 INFO juju.worker runner.go:260 start "upgrader"
2014-11-01 10:48:22 INFO juju.worker runner.go:260 start "logger"
2014-11-01 10:48:22 DEBUG juju.worker.logger logger.go:35 initial log config: "<root>=DEBUG"
2014-11-01 10:48:22 INFO juju.worker runner.go:260 start "uniter"
2014-11-01 10:48:22 DEBUG juju.worker.logger logger.go:60 logger setup
2014-11-01 10:48:22 INFO juju.worker runner.go:260 start "apiaddressupdater"
2014-11-01 10:48:22 INFO juju.worker runner.go:260 start "rsyslog"
2014-11-01 10:48:22 DEBUG juju.worker.rsyslog worker.go:75 starting rsyslog worker mode 1 for "unit-ci-airline-ts-django-0" "tarmac-local"
2014-11-01 10:48:22 DEBUG juju.worker.logger logger.go:45 reconfiguring logging from "<root>=DEBUG" to "<root>=WARNING;unit=DEBUG"
2014-11-01 10:48:39 INFO juju-log Making dir /srv/ci-airline-ts-django/code/ root:root 555
2014-11-01 10:48:39 INFO juju-log Adding dependencies.
2014-11-01 10:48:39 INFO juju-log installing apt packages...
2014-11-01 10:48:40 INFO config-changed gpg: keyring `/tmp/tmpGfAGA_/secring.gpg' created
2014-11-01 10:48:40 INFO config-changed gpg: keyring `/tmp/tmpGfAGA_/pubring.gpg' created
2014-11-01 10:48:40 INFO config-changed gpg: requesting key 6A8DFC40 from hkp server keyserver.ubuntu.com
2014-11-01 10:48:40 INFO config-changed gpg: /tmp/tmpGfAGA_/trustdb.gpg: trustdb created
2014-11-01 10:48:40 INFO config-changed gpg: key 6A8DFC40: public key "Launchpad PPA for Canonical CI Engineering" imported
2014-11-01 10:48:40 INFO config-changed gpg: Total number processed: 1
2014-11-01 10:48:40 INFO config-changed gpg: imported: 1 (RSA: 1)
2014-11-01 10:48:41 INFO config-changed OK
2014-11-01 10:48:43 INFO config-changed Hit http://archive.ubuntu.com precise Release.gpg
2014-11-01 10:48:43 INFO config-chan...

[Vincent Ladeuil (vila)]

2014-11-01 11:05:02 INFO pgsql-relation-joined OperationalError: FATAL: the database system is shutting down
2014-11-01 11:05:02 INFO pgsql-relation-joined FATAL: the database system is shutting down
2014-11-01 11:05:02 INFO pgsql-relation-joined Syncing...
2014-11-01 11:05:02 INFO juju-log pgsql:28: migration command failed, retrying...
2014-11-01 11:05:08 INFO pgsql-relation-joined OperationalError: could not connect to server: Connection refused
2014-11-01 11:05:08 INFO pgsql-relation-joined Is the server running on host "10.0.3.85" and accepting
2014-11-01 11:05:08 INFO pgsql-relation-joined TCP/IP connections on port 5432?
2014-11-01 11:05:08 INFO pgsql-relation-joined Syncing...
2014-11-01 11:05:08 INFO juju-log pgsql:28: migration command failed, retrying...
2014-11-01 11:05:13 INFO pgsql-relation-joined OperationalError: could not connect to server: Connection refused
2014-11-01 11:05:13 INFO pgsql-relation-joined Is the server running on host "10.0.3.85" and accepting
2014-11-01 11:05:13 INFO pgsql-relation-joined TCP/IP connections on port 5432?
2014-11-01 11:05:13 INFO pgsql-relation-joined Syncing...
2014-11-01 11:05:13 INFO juju-log pgsql:28: migration command failed, retrying...
2014-11-01 11:05:19 INFO pgsql-relation-joined OperationalError: could not connect to server: Connection refused
2014-11-01 11:05:19 INFO pgsql-relation-joined Is the server running on host "10.0.3.85" and accepting
2014-11-01 11:05:19 INFO pgsql-relation-joined TCP/IP connections on port 5432?
2014-11-01 11:05:19 INFO pgsql-relation-joined Syncing...
2014-11-01 11:05:19 INFO juju-log pgsql:28: migration command failed, retrying...
2014-11-01 11:05:25 INFO pgsql-relation-joined OperationalError: could not connect to server: Connection refused
2014-11-01 11:05:25 INFO pgsql-relation-joined Is the server running on host "10.0.3.85" and accepting
2014-11-01 11:05:25 INFO pgsql-relation-joined TCP/IP connections on port 5432?
2014-11-01 11:05:25 INFO pgsql-relation-joined Syncing...
2014-11-01 11:05:25 INFO juju-log pgsql:28: migration command failed, retrying...
2014-11-01 11:05:34 INFO juju-log pgsql:28: migration command failed
2014-11-01 11:05:34 INFO pgsql-relation-joined Traceback (most recent call last):
2014-11-01 11:05:34 INFO pgsql-relation-joined File "/var/lib/juju/agents/unit-ci-airline-ts-django-0/charm/hooks/pgsql-relation-joined", line 613, in <module>
2014-11-01 11:05:34 INFO pgsql-relation-joined hooks.execute(sys.argv)
2014-11-01 11:05:34 INFO pgsql-relation-joined File "/var/lib/juju/agents/unit-ci-airline-ts-django-0/charm/hooks/charmhelpers/core/hookenv.py", line 480, in execute
2014-11-01 11:05:34 INFO pgsql-relation-joined self._hooks[hook_name]()
2014-11-01 11:05:34 INFO pgsql-relation-joined File "/var/lib/juju/agents/unit-ci-airline-ts-django-0/charm/hooks/pgsql-relation-joined", line 550, in pgsql_relation_joined_changed
2014-11-01 11:05:34 INFO pgsql-relation-joined _db_migrate()
2014-11-01 11:05:34 INFO pgsql-relation-joined File "/var/lib/juju/agents/unit-ci-airline-ts-django-0/charm/hooks/pgsql-relation-joined", line 444, in _db_migrate
2014-11-01 11:05:34 INFO pgsql-relation-joined raise Exce...

=== added file 'britney_proxy/bin/uci-britney-report'
--- britney_proxy/bin/uci-britney-report	1970-01-01 00:00:00 +0000
+++ britney_proxy/bin/uci-britney-report	2014-10-31 16:39:46 +0000
@@ -0,0 +1,63 @@
+#!/usr/bin/env python
+# Ubuntu CI Engine
+# Copyright 2014 Canonical Ltd.
+
+# This program is free software: you can redistribute it and/or modify it
+# under the terms of the GNU Affero General Public License version 3, as
+# published by the Free Software Foundation.
+
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranties of
+# MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+# PURPOSE.  See the GNU Affero General Public License for more details.
+
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+"""The script to collect britney results from outside the uci-engine."""
+
+import logging
+import os
+import sys
+
+# FIXME: Add -n to handle only 'n' requests and quit (default to 1, 0 to loop
+# forver) -- vila 2014-10-30
+
+# FIXME: 'sys.path.{insert,append}' is evil and should be fixed when
+# packaging uci-engine or part of it. -- vila 2014-10-15
+
+HERE = os.path.abspath(os.path.dirname(__file__))
+# We want to be able to import from the branch root
+BRANCH_ROOT = os.path.abspath(os.path.join(HERE, '..', '..'))
+sys.path.insert(0, os.path.join(BRANCH_ROOT, 'britney_proxy'))
+sys.path.insert(0, os.path.join(BRANCH_ROOT, 'ci-utils'))
+
+
+from uciconfig import errors
+
+
+from britney import (
+    config,
+    process_reports,
+)
+from ci_utils import (
+    amqp_utils,
+    dump_stack,
+)
+
+
+if __name__ == '__main__':
+    dump_stack.install_stack_dump_signal()
+    logging.basicConfig(level=logging.INFO,
+                        format="%(asctime)s %(levelname)s %(message)s")
+    # Force amqp_utils to use our config instead of the non existant
+    # amqp_config.py one (only available for rabbit workers in uci-engine).
+    amqp_utils.get_config = config.amqp_config(config.BritneyStack())
+
+    try:
+        ret = process_reports.cli_run(sys.argv[1:], sys.stdout, sys.stderr)
+    except errors.ConfigError as e:
+        # FIXME: If one option is missing, the other mandatory ones are
+        # propably missing too, report them all. -- vila 2014-10-16
+        stderr.write('{}\n'.format(e))
+        ret = 1
+    sys.exit(ret)

=== modified file 'britney_proxy/bin/uci-britney-request'
--- britney_proxy/bin/uci-britney-request	2014-10-30 19:31:08 +0000
+++ britney_proxy/bin/uci-britney-request	2014-10-31 16:39:46 +0000
@@ -32,15 +32,17 @@
 from uciconfig import errors
 
 
-from britney import post_request
+from britney import (
+    config,
+    post_request,
+)
 from ci_utils import amqp_utils
 
 
 if __name__ == '__main__':
     # Force amqp_utils to use our config instead of the non existant
     # amqp_config.py one (only available for rabbit workers in uci-engine).
-    amqp_utils.get_config = post_request.amqp_config(
-        post_request.BritneyStack())
+    amqp_utils.get_config = config.amqp_config(config.BritneyStack())
     try:
         ret = post_request.cli_run(sys.argv[1:], sys.stdout, sys.stderr)
     except errors.ConfigError as e:

=== added file 'britney_proxy/britney/config.py'
--- britney_proxy/britney/config.py	1970-01-01 00:00:00 +0000
+++ britney_proxy/britney/config.py	2014-10-31 16:39:46 +0000
@@ -0,0 +1,83 @@
+# Ubuntu CI Engine
+# Copyright 2014 Canonical Ltd.
+
+# This program is free software: you can redistribute it and/or modify it
+# under the terms of the GNU Affero General Public License version 3, as
+# published by the Free Software Foundation.
+
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranties of
+# MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+# PURPOSE.  See the GNU Affero General Public License for more details.
+
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+"""Configuration options related to the britney proxy."""
+
+import os
+
+
+from uciconfig import (
+    options,
+    stacks,
+    stores,
+)
+
+
+BritneyStore = stores.FileStore
+
+
+def user_config_dir():
+    conf_dir = os.environ.get('XDG_CONFIG_HOME',
+                              os.path.expanduser('~/.config'))
+    return conf_dir
+
+
+class BritneyStack(stacks.Stack):
+    """Per-user options."""
+
+    def __init__(self):
+        """Make a new stack for britney interactions with the uci engine.
+
+        The options are searched in ~/.config/uci-britney.conf.
+        """
+        upath = os.path.join(user_config_dir(), 'uci-britney.conf')
+        user_store = self.get_shared_store(BritneyStore(upath))
+        super(BritneyStack, self).__init__(
+            # We only care about the no name section
+            [stacks.NameMatcher(user_store, None).get_sections],
+            user_store, mutable_section_id=None)
+
+
+def register(option):
+    options.option_registry.register(option)
+
+
+register(options.Option('uci.rabbit.host',
+                        default=options.MANDATORY,
+                        help_string='''\
+The host:port address for the uci-britney rabbit server.
+'''))
+register(options.Option('uci.rabbit.user',
+                        default=options.MANDATORY,
+                        help_string='''\
+The user name for the uci-britney rabbit server.
+'''))
+register(options.Option('uci.rabbit.password',
+                        default=options.MANDATORY,
+                        help_string='''\
+The user password for the uci-britney rabbit server.
+'''))
+
+
+def amqp_config(conf):
+    """Create the rabbit config from the britney one."""
+    class AmqpConfig(object):
+
+        def __init__(self):
+            self.AMQP_HOST = conf.get('uci.rabbit.host')
+            self.AMQP_VHOST = '/'
+            self.AMQP_USER = conf.get('uci.rabbit.user')
+            self.AMQP_PASSWORD = conf.get('uci.rabbit.password')
+
+    return AmqpConfig

=== modified file 'britney_proxy/britney/post_request.py'
--- britney_proxy/britney/post_request.py	2014-10-15 14:55:04 +0000
+++ britney_proxy/britney/post_request.py	2014-10-31 16:39:46 +0000
@@ -15,17 +15,9 @@
 
 
 import argparse
-import os
 import sys
 
 
-from uciconfig import (
-    options,
-    stacks,
-    stores,
-)
-
-
 from britney import queues
 
 
@@ -87,74 +79,18 @@
             sys.stderr = err_orig
 
 
-BritneyStore = stores.FileStore
-
-
-def user_config_dir():
-    conf_dir = os.environ.get('XDG_CONFIG_HOME',
-                              os.path.expanduser('~/.config'))
-    return conf_dir
-
-
-class BritneyStack(stacks.Stack):
-    """Per-user options."""
-
-    def __init__(self):
-        """Make a new stack for britney interactions with the uci engine.
-
-        The options are searched in ~/.config/uci-britney.conf.
-        """
-        upath = os.path.join(user_config_dir(), 'uci-britney.conf')
-        user_store = self.get_shared_store(BritneyStore(upath))
-        super(BritneyStack, self).__init__(
-            # We only care about the no name section
-            [stacks.NameMatcher(user_store, None).get_sections],
-            user_store, mutable_section_id=None)
-
-
-def register(option):
-    options.option_registry.register(option)
-
-
-register(options.Option('uci.rabbit.host',
-                        default=options.MANDATORY,
-                        help_string='''\
-The host:port address for the uci-britney rabbit server.
-'''))
-register(options.Option('uci.rabbit.user',
-                        default=options.MANDATORY,
-                        help_string='''\
-The user name for the uci-britney rabbit server.
-'''))
-register(options.Option('uci.rabbit.password',
-                        default=options.MANDATORY,
-                        help_string='''\
-The user password for the uci-britney rabbit server.
-'''))
-
-
 def post(queue, series, architecture, package, output=None, report=None):
     msg = dict(series=series, architecture=architecture, package=package)
     if output is not None:
         msg['output_queue'] = output
     if report is not None:
         msg['report_queue'] = report
+    # FIXME: Error checking to guarantee that we at least give a proper error
+    # message. Known failures: bad host (can't connect), bad credentials (can't
+    # connect). Possible failures: rabbit down. -- vila 2014-10-24
     queue.publish(msg)
 
 
-def amqp_config(conf):
-    """Create the rabbit config from the britney one."""
-    class AmqpConfig(object):
-
-        def __init__(self):
-            self.AMQP_HOST = conf.get('uci.rabbit.host')
-            self.AMQP_VHOST = '/'
-            self.AMQP_USER = conf.get('uci.rabbit.user')
-            self.AMQP_PASSWORD = conf.get('uci.rabbit.password')
-
-    return AmqpConfig
-
-
 def cli_run(args, stdout, stderr):
     """Post a britney test request from the command line."""
     parser = PostRequestArgParser()

=== added file 'britney_proxy/britney/process_reports.py'
--- britney_proxy/britney/process_reports.py	1970-01-01 00:00:00 +0000
+++ britney_proxy/britney/process_reports.py	2014-10-31 16:39:46 +0000
@@ -0,0 +1,179 @@
+#!/usr/bin/env python
+# Ubuntu CI Engine
+# Copyright 2014 Canonical Ltd.
+
+# This program is free software: you can redistribute it and/or modify it
+# under the terms of the GNU Affero General Public License version 3, as
+# published by the Free Software Foundation.
+
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranties of
+# MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+# PURPOSE.  See the GNU Affero General Public License for more details.
+
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+from __future__ import unicode_literals
+
+
+import argparse
+import errno
+import os
+import json
+import logging
+import sys
+
+
+from ci_utils import amqp_utils
+
+
+class BritneyReportHandler(object):
+    """Process a britney test report.
+
+    This is fed by messages received on a queue or directly for tests by
+    calling the ``handle()`` method.
+    """
+
+    def __init__(self, output_dir):
+        self.output_dir = output_dir
+        try:
+            # Try to create the needed dirs
+            os.makedirs(self.output_dir)
+        except OSError as e:
+            # They are already there, no worries
+            if e.errno != errno.EEXIST:
+                raise
+
+    def handle(self, request):
+        """Handle a report request.
+
+        :param request: The request describing a britney result to process.
+
+        This creates a file in the 'output_dir' directory under a name and with
+        the content expected by britney.
+
+        The name is something like:
+        {series}_{arch}_{package}-{DATE}_{HOUR}[_{whatever}].result
+
+        The content is (all fields on a single line separated by spaces):
+        {series} {arch} {package} {version} {PASS|FAILED} [{dep} {dep_version]*
+
+        If an error occured while setting up the testbed (by adt-run) we get
+        only:
+         {series} {arch} {package}
+        """
+
+        # From 'result_at' we get info for the path
+        store_prefix = request['result_at']
+        # The prefix has the timestamp
+        # Sample: trusty/amd64/libp/libpng/20141001_000000_localhost
+        stamp = store_prefix.split('/')[4]
+        day, hour = stamp.split('_')[:2]
+
+        # From 'result' we get the series, arch and package parts
+        result = request['britney_result']
+        # The first 3 fields are guaranteed to exist.
+        series, arch, package = result.split()[:3]
+        logging.info('{} {} {}'.format(series, arch, package))
+
+        path = os.path.join(self.output_dir, '{}_{}_{}_{}-{}.result'.format(
+            series, arch, package, day, hour))
+        with open(path, 'wb') as f:
+            f.write(result)
+
+
+class BritneyReportsQueue(object):
+    """The queue receiving the reports for the britney results."""
+
+    def __init__(self, queue_name, request_handler, max_reports=0):
+        """Britney reports queue.
+
+        :param queue_name: The queue name where the reports are received.
+
+        :param request_handler: The handler that processes the reports.
+
+        :param max_reports: Max number of reports to handle before
+            quitting. The default value (0) is used to never quit.
+        """
+        self.queue_name = queue_name
+        self.request_handler = request_handler
+        self.max_reports = max_reports
+        self.nb_reports = 0
+
+    def consume(self):
+        conf = amqp_utils.get_config()
+        amqp_utils.process_queue(conf, self.queue_name, self.handle_request)
+
+    def handle_request(self, msg):
+        logging.debug('Will handle {}'.format(msg.body))
+        body = json.loads(msg.body)
+        ret = self.request_handler.handle(body)
+        msg.channel.basic_ack(msg.delivery_tag)
+        logging.debug('Handling returned: {} for {}'.format(ret, msg.body))
+        self.nb_reports += 1
+        if self.max_reports and self.nb_reports >= self.max_reports:
+            # Leave the loop
+            msg.channel.basic_cancel(msg.consumer_tag)
+        return ret
+
+
+class ProcessReportArgParser(argparse.ArgumentParser):
+
+    def __init__(self, prog=None, description=None):
+        if prog is None:
+            prog = 'uci-britney-report'
+        if description is None:
+            description = 'Process a test report from britney.'
+        super(ProcessReportArgParser, self).__init__(prog=prog,
+                                                     description=description)
+        self.add_argument(
+            'report', metavar='REPORT_QUEUE',
+            help='The REPORT_QUEUE publishing the test results.')
+        self.add_argument(
+            'output', metavar='OUTPUT',
+            help='The OUTPUT directory where the results are stored.')
+        # Optional arguments
+        self.add_argument(
+            '--nb-reports', '-n', metavar='REPORTS', default=1, type=int,
+            help='The number of reports to process from the queue'
+            ' named REPORT_QUEUE.')
+
+    def parse_args(self, args=None, out=None, err=None):
+        """Parse arguments, overridding stdout/stderr if provided.
+
+        Overridding stdout/stderr is provided for tests to address arpgarse
+        hardcoding sys.{stdout,stderr} usage.
+
+        :params args: The arguments to the script.
+
+        :param out: Default to sys.stdout.
+
+        :param err: Default to sys.stderr.
+
+        :return: The populated namespace.
+
+        """
+        out_orig = sys.stdout
+        err_orig = sys.stderr
+        try:
+            if out is not None:
+                sys.stdout = out
+            if err is not None:
+                sys.stderr = err
+            return super(ProcessReportArgParser, self).parse_args(args)
+        finally:
+            sys.stdout = out_orig
+            sys.stderr = err_orig
+
+
+def cli_run(args, stdout, stderr):
+    """Process britney test reports from the command line."""
+    parser = ProcessReportArgParser()
+    opts = parser.parse_args(args, out=stdout, err=stderr)
+    request_handler = BritneyReportHandler(opts.output)
+    queue = BritneyReportsQueue(opts.report, request_handler,
+                                max_reports=opts.nb_reports)
+    if opts.nb_reports == 0:
+        sys.stderr.write('Waiting for reports. ^C to exit.')
+    queue.consume()
+    return 0

=== added file 'britney_proxy/britney/tests/test_config.py'
--- britney_proxy/britney/tests/test_config.py	1970-01-01 00:00:00 +0000
+++ britney_proxy/britney/tests/test_config.py	2014-10-31 16:39:46 +0000
@@ -0,0 +1,55 @@
+# Copyright 2014 Canonical Ltd.
+
+# This program is free software: you can redistribute it and/or modify it
+# under the terms of the GNU Affero General Public License version 3, as
+# published by the Free Software Foundation.
+
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranties of
+# MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+# PURPOSE.  See the GNU Affero General Public License for more details.
+
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+import os
+import unittest
+
+
+from ucitests import fixtures
+
+
+from britney import config
+
+
+class TestConfigDir(unittest.TestCase):
+
+    def setUp(self):
+        super(TestConfigDir, self).setUp()
+        fixtures.set_uniq_cwd(self)
+        fixtures.isolate_from_env(self, dict(HOME=self.uniq_dir,
+                                             XDG_CONFIG_HOME=None))
+
+    def test_default(self):
+        conf_dir = os.path.join(self.uniq_dir, '.config')
+        self.assertEqual(conf_dir, config.user_config_dir())
+
+    def test_xdg_config_home_override(self):
+        xdg_dir = os.path.join(self.uniq_dir, 'xdg')
+        os.environ['XDG_CONFIG_HOME'] = xdg_dir
+        self.assertEqual(xdg_dir, config.user_config_dir())
+
+
+class TestConfig(unittest.TestCase):
+
+    def setUp(self):
+        super(TestConfig, self).setUp()
+        fixtures.set_uniq_cwd(self)
+        fixtures.isolate_from_env(self, dict(HOME=self.uniq_dir,
+                                             XDG_CONFIG_HOME=None))
+        self.config = config.BritneyStack()
+
+    def test_empty_config_errors(self):
+        with self.assertRaises(Exception) as cm:
+            self.config.get('uci.rabbit.host')
+        self.assertEqual('uci.rabbit.host must be set.', unicode(cm.exception))

=== modified file 'britney_proxy/britney/tests/test_post_request.py'
--- britney_proxy/britney/tests/test_post_request.py	2014-10-15 14:29:40 +0000
+++ britney_proxy/britney/tests/test_post_request.py	2014-10-31 16:39:46 +0000
@@ -13,14 +13,10 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 from cStringIO import StringIO
-import os
 import unittest
 
 
-from ucitests import (
-    assertions,
-    fixtures as uci_fixtures,
-)
+from ucitests import assertions
 
 
 from britney import post_request
@@ -60,39 +56,6 @@
         self.assertEqual('', self.err.getvalue())
 
 
-class TestConfigDir(unittest.TestCase):
-
-    def setUp(self):
-        super(TestConfigDir, self).setUp()
-        uci_fixtures.set_uniq_cwd(self)
-        uci_fixtures.isolate_from_env(self, dict(HOME=self.uniq_dir,
-                                                 XDG_CONFIG_HOME=None))
-
-    def test_default(self):
-        conf_dir = os.path.join(self.uniq_dir, '.config')
-        self.assertEqual(conf_dir, post_request.user_config_dir())
-
-    def test_xdg_config_home_override(self):
-        xdg_dir = os.path.join(self.uniq_dir, 'xdg')
-        os.environ['XDG_CONFIG_HOME'] = xdg_dir
-        self.assertEqual(xdg_dir, post_request.user_config_dir())
-
-
-class TestConfig(unittest.TestCase):
-
-    def setUp(self):
-        super(TestConfig, self).setUp()
-        uci_fixtures.set_uniq_cwd(self)
-        uci_fixtures.isolate_from_env(self, dict(HOME=self.uniq_dir,
-                                                 XDG_CONFIG_HOME=None))
-        self.config = post_request.BritneyStack()
-
-    def test_empty_config_errors(self):
-        with self.assertRaises(Exception) as cm:
-            self.config.get('uci.rabbit.host')
-        self.assertEqual('uci.rabbit.host must be set.', unicode(cm.exception))
-
-
 class TestPost(unittest.TestCase):
 
     def test_post_simple(self):

=== added file 'britney_proxy/britney/tests/test_process_reports.py'
--- britney_proxy/britney/tests/test_process_reports.py	1970-01-01 00:00:00 +0000
+++ britney_proxy/britney/tests/test_process_reports.py	2014-10-31 16:39:46 +0000
@@ -0,0 +1,112 @@
+# Ubuntu CI Engine
+# Copyright 2014 Canonical Ltd.
+
+# This program is free software: you can redistribute it and/or modify it
+# under the terms of the GNU Affero General Public License version 3, as
+# published by the Free Software Foundation.
+
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranties of
+# MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+# PURPOSE.  See the GNU Affero General Public License for more details.
+
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+from cStringIO import StringIO
+import os
+import unittest
+
+
+from ucitests import fixtures as fixtures
+
+
+from britney import process_reports
+
+
+class TestBritneyReportHandlerErrors(unittest.TestCase):
+
+    def setUp(self):
+        super(TestBritneyReportHandlerErrors, self).setUp()
+        self.handler = process_reports.BritneyReportHandler('unused')
+
+    def assertError(self, exc_class, exc_msg, request):
+        with self.assertRaises(exc_class) as cm:
+            self.handler.handle(request)
+        self.assertEqual(exc_msg, cm.exception.message)
+
+    def test_empty_message(self):
+        self.assertError(KeyError, 'result_at', dict())
+
+    def test_wrong_prefix(self):
+        self.assertError(IndexError, 'list index out of range',
+                         dict(result_at='xxx'))
+
+    def test_wrong_date(self):
+        self.assertError(ValueError, 'need more than 1 value to unpack',
+                         dict(result_at='trusty/amd64/libp/libpng/xxx',
+                              britney_result='trusty amd64 libpng'))
+
+    def test_empty_result(self):
+        self.assertError(
+            ValueError, 'need more than 0 values to unpack',
+            dict(result_at='trusty/amd64/libp/libpng/yymmdd_hhmmss',
+                 britney_result=''))
+
+
+class TestBritneyReportHandler(unittest.TestCase):
+
+    def setUp(self):
+        super(TestBritneyReportHandler, self).setUp()
+        fixtures.set_uniq_cwd(self)
+        prefix = 'trusty/amd64/'
+        self.handler = process_reports.BritneyReportHandler(prefix)
+
+    def test_result_file_created(self):
+        result = 'trusty amd64 libpng'
+        self.handler.handle(
+            dict(result_at='trusty/amd64/libp/libpng/yymmdd_hhmmss',
+                 britney_result=result))
+        result_path = 'trusty/amd64/trusty_amd64_libpng_yymmdd-hhmmss.result'
+        self.assertTrue(os.path.exists(result_path),
+                        '{} is not there'.format(result_path))
+        with open(result_path) as f:
+            self.assertEqual(result, f.read())
+
+
+class TestCliRun(unittest.TestCase):
+    "Smoke blackbox tests."""
+
+    def setUp(self):
+        super(TestCliRun, self).setUp()
+        self.out = StringIO()
+        self.err = StringIO()
+
+    def test_run_no_args_errors(self):
+        with self.assertRaises(SystemExit):
+            process_reports.cli_run([], self.out, self.err)
+
+
+class TestOptionParsing(unittest.TestCase):
+
+    def setUp(self):
+        super(TestOptionParsing, self).setUp()
+        self.out = StringIO()
+        self.err = StringIO()
+
+    def parse_args(self, args):
+        ns = process_reports.ProcessReportArgParser().parse_args(
+            args, self.out, self.err)
+        return ns
+
+    def test_default_values(self):
+        ns = self.parse_args(['reports', 'output'])
+        self.assertEqual('output', ns.output)
+        self.assertEqual('reports', ns.report)
+        self.assertEqual(1, ns.nb_reports)
+        self.assertEqual('', self.out.getvalue())
+        self.assertEqual('', self.err.getvalue())
+
+    def test_nb_reports(self):
+        ns = self.parse_args(['reports', 'output', '-n0'])
+        self.assertEqual(0, ns.nb_reports)