Merge lp:~vila/uci-engine/britney-config-fallout into lp:uci-engine

Proposed by Vincent Ladeuil on 2015-01-08
Status: Merged
Approved by: Vincent Ladeuil on 2015-01-09
Approved revision: 916
Merged at revision: 917
Proposed branch: lp:~vila/uci-engine/britney-config-fallout
Merge into: lp:uci-engine
Diff against target: 37 lines (+5/-4)
1 file modified
tests/test_britney.py (+5/-4)
To merge this branch: bzr merge lp:~vila/uci-engine/britney-config-fallout
Reviewer Review Type Date Requested Status
Paul Larson 2015-01-08 Approve on 2015-01-08
Review via email: mp+245834@code.launchpad.net

Commit message

Fix fallout from an old refactoring moving the config part out of britney/post_request.py.

Description of the change

Last spin-off from nova-failure: this fixes a fallout missed in an old britney-related refactoring.

The root cause is that we don't run the tests against different deployments in tarmac which is a known issue but shouldn't block that fix either.

To post a comment you must log in.
Paul Larson (pwlars) wrote :

looks straightforward enough, I see those things moved. +1

review: Approve
Ubuntu CI Bot (uci-bot) wrote :
Download full text (59.8 KiB)

The attempt to merge lp:~vila/uci-engine/britney-config-fallout into lp:uci-engine failed. Below is the output from the failed tests.

2015-01-08 17:31:52 INFO juju.cmd supercommand.go:37 running jujud [1.20.14.1-precise-amd64 gc]
2015-01-08 17:31:52 DEBUG juju.agent agent.go:377 read agent config, format "1.18"
2015-01-08 17:31:52 INFO juju.jujud unit.go:78 unit agent unit-ci-airline-ts-django-0 start (1.20.14.1-precise-amd64 [gc])
2015-01-08 17:31:52 INFO juju.worker runner.go:260 start "api"
2015-01-08 17:31:52 INFO juju.state.api apiclient.go:242 dialing "wss://10.0.3.1:17070/"
2015-01-08 17:31:52 INFO juju.state.api apiclient.go:176 connection established to "wss://10.0.3.1:17070/"
2015-01-08 17:31:52 INFO juju.state.api apiclient.go:242 dialing "wss://10.0.3.1:17070/"
2015-01-08 17:31:52 INFO juju.state.api apiclient.go:176 connection established to "wss://10.0.3.1:17070/"
2015-01-08 17:31:52 INFO juju.state.api apiclient.go:242 dialing "wss://10.0.3.1:17070/"
2015-01-08 17:31:52 INFO juju.state.api apiclient.go:176 connection established to "wss://10.0.3.1:17070/"
2015-01-08 17:31:53 INFO juju.worker runner.go:260 start "upgrader"
2015-01-08 17:31:53 INFO juju.worker runner.go:260 start "logger"
2015-01-08 17:31:53 DEBUG juju.worker.logger logger.go:35 initial log config: "<root>=DEBUG"
2015-01-08 17:31:53 INFO juju.worker runner.go:260 start "uniter"
2015-01-08 17:31:53 DEBUG juju.worker.logger logger.go:60 logger setup
2015-01-08 17:31:53 INFO juju.worker runner.go:260 start "apiaddressupdater"
2015-01-08 17:31:53 INFO juju.worker runner.go:260 start "rsyslog"
2015-01-08 17:31:53 DEBUG juju.worker.rsyslog worker.go:75 starting rsyslog worker mode 1 for "unit-ci-airline-ts-django-0" "tarmac-local"
2015-01-08 17:31:53 DEBUG juju.worker.logger logger.go:45 reconfiguring logging from "<root>=DEBUG" to "<root>=WARNING;unit=DEBUG"
2015-01-08 17:32:12 INFO juju-log Making dir /srv/ci-airline-ts-django/code/ root:root 555
2015-01-08 17:32:12 INFO juju-log Adding dependencies.
2015-01-08 17:32:12 INFO juju-log installing apt packages...
2015-01-08 17:32:15 INFO config-changed gpg: keyring `/tmp/tmpBBCrhv/secring.gpg' created
2015-01-08 17:32:15 INFO config-changed gpg: keyring `/tmp/tmpBBCrhv/pubring.gpg' created
2015-01-08 17:32:15 INFO config-changed gpg: requesting key 6A8DFC40 from hkp server keyserver.ubuntu.com
2015-01-08 17:32:15 INFO config-changed gpg: /tmp/tmpBBCrhv/trustdb.gpg: trustdb created
2015-01-08 17:32:15 INFO config-changed gpg: key 6A8DFC40: public key "Launchpad PPA for Canonical CI Engineering" imported
2015-01-08 17:32:15 INFO config-changed gpg: Total number processed: 1
2015-01-08 17:32:15 INFO config-changed gpg: imported: 1 (RSA: 1)
2015-01-08 17:32:16 INFO config-changed OK
2015-01-08 17:32:23 INFO config-changed Hit http://archive.ubuntu.com precise Release.gpg
2015-01-08 17:32:23 INFO config-changed Get:1 http://ppa.launchpad.net precise Release.gpg [316 B]
2015-01-08 17:32:24 INFO config-changed Get:2 http://ubuntu-cloud.archive.canonical.com precise-updates/cloud-tools Release.gpg [543 B]
2015-01-08 17:32:24 INFO config-changed Get:3 http://ppa.launchpad.net prec...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/test_britney.py'
2--- tests/test_britney.py 2014-11-03 12:59:48 +0000
3+++ tests/test_britney.py 2015-01-08 10:52:07 +0000
4@@ -1,6 +1,6 @@
5 #!/usr/bin/env python
6 # Ubuntu Continuous Integration Engine
7-# Copyright 2014 Canonical Ltd.
8+# Copyright 2014, 2015 Canonical Ltd.
9
10 # This program is free software: you can redistribute it and/or modify it
11 # under the terms of the GNU Affero General Public License version 3, as
12@@ -37,6 +37,7 @@
13
14
15 from britney import (
16+ config,
17 post_request,
18 process_results,
19 )
20@@ -186,15 +187,15 @@
21 password = 's3cr3t'
22 rabbit_ip = get_rabbit_ip(status)
23 deployers.expose_rabbit(self, rabbit_ip, user, password)
24- os.makedirs(post_request.user_config_dir())
25- self.config = post_request.BritneyStack()
26+ os.makedirs(config.user_config_dir())
27+ self.config = config.BritneyStack()
28 self.config.store._load_from_string('''\
29 uci.rabbit.host = {rabbit_ip}
30 uci.rabbit.user = {user}
31 uci.rabbit.password = {password}
32 '''.format(**locals()))
33 fixtures.patch(self, amqp_utils, 'get_config',
34- post_request.amqp_config(self.config))
35+ config.amqp_config(self.config))
36 self.out = StringIO()
37 self.err = StringIO()
38

Subscribers

People subscribed via source and target branches