Merge lp:~vila/uci-engine/1323498-fix-unit-renames into lp:uci-engine

Proposed by Vincent Ladeuil
Status: Merged
Approved by: Vincent Ladeuil
Approved revision: 512
Merged at revision: 512
Proposed branch: lp:~vila/uci-engine/1323498-fix-unit-renames
Merge into: lp:uci-engine
Diff against target: 125 lines (+15/-11)
6 files modified
tests/test_image_builder.py (+3/-2)
tests/test_integration.py (+3/-2)
tests/test_juju_gui.py (+1/-1)
tests/test_ppa_assigner.py (+2/-2)
tests/test_test_runner.py (+2/-1)
tests/test_ticket_system.py (+4/-3)
To merge this branch: bzr merge lp:~vila/uci-engine/1323498-fix-unit-renames
Reviewer Review Type Date Requested Status
Andy Doan (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+221059@code.launchpad.net

Commit message

Fix test failures introduced while renaming the services in an IS compatible way.

Description of the change

This fixes the fallout from revno 506: tests were referring to the old service names without the introduced 'ci-airline-' prefix.

I'm waiting for a test run to complete but I think I've got all references fixed.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:512
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/707/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/707/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andy Doan (doanac) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/test_image_builder.py'
2--- tests/test_image_builder.py 2014-04-17 20:13:11 +0000
3+++ tests/test_image_builder.py 2014-05-27 10:32:39 +0000
4@@ -21,14 +21,15 @@
5 import deployers
6
7
8-class TestTestRunner(deployers.DeployerTest):
9+class TestImageBuilder(deployers.DeployerTest):
10 """Integration tests for image builder service run on a juju deployment"""
11
12 deployer_cfg = 'image-builder.yaml'
13
14 def test_worker_running(self):
15 '''ensure the rabbit worker is deployed and running'''
16- self.assert_job_running('imagebuild_worker', 'imagebuild-worker')
17+ self.assert_job_running('ci_airline_imagebuild_worker',
18+ 'ci-airline-imagebuild-worker')
19
20
21 if __name__ == "__main__":
22
23=== modified file 'tests/test_integration.py'
24--- tests/test_integration.py 2014-05-07 14:41:07 +0000
25+++ tests/test_integration.py 2014-05-27 10:32:39 +0000
26@@ -72,7 +72,7 @@
27 args = '%s develop' % p
28 run_virtual_env(self.temp_dir, args)
29 config_url = 'http://{}'.format(
30- self.get_ip_and_port('webui-apache')[0])
31+ self.get_ip_and_port('ci-airline-webui-apache')[0])
32 config = os.path.join(os.environ["HOME"], '.ubuntu-ci')
33 with open(config, 'a') as fp:
34 fp.write('ci_url: "{}"\n'.format(config_url))
35@@ -80,7 +80,8 @@
36 run_virtual_env(self.temp_dir, args='create')
37 self.addCleanup(delete_virtual_env, self.temp_dir)
38
39- def get_server_status_and_content(self, url, service='webui-apache'):
40+ def get_server_status_and_content(self, url,
41+ service='ci-airline-webui-apache'):
42 final_url = url.format(self.get_ip_and_port(service)[0])
43
44 client = httplib2.Http()
45
46=== modified file 'tests/test_juju_gui.py'
47--- tests/test_juju_gui.py 2014-05-12 18:48:34 +0000
48+++ tests/test_juju_gui.py 2014-05-27 10:32:39 +0000
49@@ -29,7 +29,7 @@
50 def get_unit(self):
51 status = amulet.waiter.status(
52 self.deployer.deployment.juju_env)
53- unit = status['services']['ci-juju-gui']['units'].values()[0]
54+ unit = status['services']['ci-airline-juju-gui']['units'].values()[0]
55 return unit
56
57 def test_juju_gui(self):
58
59=== modified file 'tests/test_ppa_assigner.py'
60--- tests/test_ppa_assigner.py 2014-04-16 18:36:03 +0000
61+++ tests/test_ppa_assigner.py 2014-05-27 10:32:39 +0000
62@@ -29,7 +29,7 @@
63 deployer_cfg = 'ppa-assigner.yaml'
64
65 def get_server_status_and_content(self, url):
66- final_url = url.format(*self.get_ip_and_port('ppa-django'))
67+ final_url = url.format(*self.get_ip_and_port('ci-airline-ppa-django'))
68
69 # Issue a simple command against the ppa assigner API
70 client = httplib2.Http()
71@@ -39,7 +39,7 @@
72
73 def reserve_ppa(self, ticket_id):
74 url = 'http://{}:{}/api/v1/ppa/'
75- final_url = url.format(*self.get_ip_and_port('ppa-django'))
76+ final_url = url.format(*self.get_ip_and_port('ci-airline-ppa-django'))
77
78 client = httplib2.Http()
79 resp, content = client.request(
80
81=== modified file 'tests/test_test_runner.py'
82--- tests/test_test_runner.py 2014-04-17 20:13:11 +0000
83+++ tests/test_test_runner.py 2014-05-27 10:32:39 +0000
84@@ -26,7 +26,8 @@
85
86 def test_worker_running(self):
87 '''Ensure the rabbit worker is deployed and running.'''
88- self.assert_job_running('tr_rabbit_worker', 'tr-rabbit-worker')
89+ self.assert_job_running('ci_airline_tr_rabbit_worker',
90+ 'ci-airline-tr-rabbit-worker')
91
92
93 if __name__ == "__main__":
94
95=== modified file 'tests/test_ticket_system.py'
96--- tests/test_ticket_system.py 2014-05-26 12:51:46 +0000
97+++ tests/test_ticket_system.py 2014-05-27 10:32:39 +0000
98@@ -32,7 +32,7 @@
99 # Adding get_ip_and_port('ts-django') in order to allow the deployment
100 # further time to settle before running the tests.
101 # http://pad.lv/1319077
102- self.get_ip_and_port('ts-django')
103+ self.get_ip_and_port('ci-airline-ts-django')
104
105 def get_server_status_and_content(self, url):
106 final_url = url.format(self.get_ip_and_port('webui-apache')[0])
107@@ -45,7 +45,8 @@
108
109 def create_ticket(self, ticket_content):
110 url = 'http://{}/api/v1/ticket/'
111- final_url = url.format(self.get_ip_and_port('webui-apache')[0])
112+ final_url = url.format(
113+ self.get_ip_and_port('ci-airline-webui-apache')[0])
114
115 client = httplib2.Http()
116 resp, content = client.request(
117@@ -58,7 +59,7 @@
118
119 def test_ticket_sys_api(self):
120 url = 'http://{}/api/v1/ticket'
121- self.get_ip_and_port('ts-django')
122+ self.get_ip_and_port('ci-airline-ts-django')
123 resp, content = self.get_server_status_and_content(url)
124
125 self.assertEqual('200', resp['status'])

Subscribers

People subscribed via source and target branches