Code review comment for lp:~vila/ubuntu-ci-services-itself/1293625-no-built-binaries

Revision history for this message
Vincent Ladeuil (vila) wrote :

> Makes sense, which packages did you try running this with?

libpng

This package requires that *some* test deps are compiled but not the package library itself.

> Would feel more
> comfortable knowing it was tried with some package that normally has to be
> compiled, but doesn't request it in the restrictions to see

'has to be compiled'is a configuration that should not exist. It would mean the package is not testing the installed version which is what dep-8 tests are about.

> that 1. it doesn't
> compile it, and 2. the tests still pass since the binary package is installed.

But *that* is what I tested, test passing despite not compiling the package.

> Otherwise, +1

« Back to merge proposal