Merge lp:~vila/u1-test-utils/1172265-display-pep8-failures into lp:u1-test-utils

[Vincent Ladeuil]

Display pep8 failures as they occur.

This fixes bug #1172265 by displaying pep8 failures as they occur.

An alternate and more invasive fix would be to collect errors and have them
displayed when the test failure is reported.

I postponed that additional fix as some infrastructure a la testtools
addDetail sounds like a perfect match and I don't want to re-invent the
wheel here. Should the need arise though, I'd rather have testtools as a
dependency first (after all, sst is a dependency here and uses testtools
itself).

[Leo Arias (elopio)]

review: Approve (code review, tested in real life)

=== modified file 'u1testutils/static/test_pep8_conformance.py'
--- u1testutils/static/test_pep8_conformance.py	2012-12-03 17:52:45 +0000
+++ u1testutils/static/test_pep8_conformance.py	2013-04-24 13:09:05 +0000
@@ -25,22 +25,17 @@
     packages = []
     exclude = []
 
-    def message(self, text):
-        self.errors.append(text)
-
     def setUp(self):
-        self.errors = {}
         self.pep8style = pep8.StyleGuide(
             counters=defaultdict(int),
             doctest='',
             exclude=self.exclude,
             filename=['*.py'],
             ignore=[],
-            messages=self.errors,
             repeat=True,
             select=[],
             show_pep8=False,
-            show_source=False,
+            show_source=True,
             max_line_length=79,
             quiet=0,
             statistics=False,
@@ -51,6 +46,4 @@
     def test_pep8_conformance(self):
         for package in self.packages:
             self.pep8style.input_dir(os.path.dirname(package.__file__))
-        # FIXME: When this fails, the offending lines are not displayed, they
-        # should. -- vila 2012-10-19
         self.assertEqual(self.pep8style.options.report.total_errors, 0)