Merge lp:~vila/ols-store-tests/no-more-channels-for-cpi into lp:~ubuntuone-pqm-team/ols-store-tests/store-acceptance-tests

Proposed by Vincent Ladeuil
Status: Merged
Approved by: Vincent Ladeuil
Approved revision: 42
Merged at revision: 41
Proposed branch: lp:~vila/ols-store-tests/no-more-channels-for-cpi
Merge into: lp:~ubuntuone-pqm-team/ols-store-tests/store-acceptance-tests
Diff against target: 41 lines (+1/-4)
3 files modified
run-landing-tests.sh (+1/-1)
tests/api/cpi/test_package.py (+0/-2)
tests/api/cpi/test_snaps.py (+0/-1)
To merge this branch: bzr merge lp:~vila/ols-store-tests/no-more-channels-for-cpi
Reviewer Review Type Date Requested Status
Facundo Batista (community) Approve
Ricardo Kirkner (community) Approve
Review via email: mp+319682@code.launchpad.net

Commit message

Fix recent failures caused by 'channels' being dropped from cpi responses.

Description of the change

Fix recent failures caused by 'channels' being dropped from cpi responses.

To post a comment you must log in.
Revision history for this message
Ricardo Kirkner (ricardokirkner) :
review: Approve
Revision history for this message
Facundo Batista (facundo) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'run-landing-tests.sh'
2--- run-landing-tests.sh 2017-03-03 16:00:51 +0000
3+++ run-landing-tests.sh 2017-03-13 11:59:03 +0000
4@@ -5,4 +5,4 @@
5 SECRETS=~/.config/ols-store-acceptance-tests/secrets
6 test -f ${SECRETS} && . ${SECRETS}
7
8-PYTHONPATH=`pwd` env/bin/python3 /usr/bin/ols-run-tests
9+PYTHONPATH=`pwd` env/bin/python3 /usr/bin/ols-run-tests $*
10
11=== modified file 'tests/api/cpi/test_package.py'
12--- tests/api/cpi/test_package.py 2017-03-01 15:54:06 +0000
13+++ tests/api/cpi/test_package.py 2017-03-13 11:59:03 +0000
14@@ -47,7 +47,6 @@
15 'blacklist_country_codes',
16 'changelog',
17 'channel',
18- 'channels',
19 'click_framework',
20 'click_version',
21 'company_name',
22@@ -106,7 +105,6 @@
23 self.assertEqual(body['package_name'], name)
24 if channel is not None:
25 self.assertEqual(body['channel'], channel)
26- self.assertIn(channel, body['channels'])
27 if revision is not None:
28 self.assertEqual(body['revision'], revision)
29
30
31=== modified file 'tests/api/cpi/test_snaps.py'
32--- tests/api/cpi/test_snaps.py 2017-03-01 15:54:06 +0000
33+++ tests/api/cpi/test_snaps.py 2017-03-13 11:59:03 +0000
34@@ -37,7 +37,6 @@
35 'blacklist_country_codes',
36 'changelog',
37 'channel',
38- 'channels',
39 'click_framework',
40 'click_version',
41 'company_name',

Subscribers

People subscribed via source and target branches