Merge ~vila/gpgservice:pass into gpgservice:master
- Git
- lp:~vila/gpgservice
- pass
- Merge into master
Status: | Needs review |
---|---|
Proposed branch: | ~vila/gpgservice:pass |
Merge into: | gpgservice:master |
Diff against target: |
28 lines (+4/-2) 2 files modified
Makefile (+1/-1) gpgservice/tests/test_webapp.py (+3/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Otto Co-Pilot | Needs Fixing | ||
Review via email: mp+306475@code.launchpad.net |
Commit message
Ensure dev wheels are available in the dependencies branch so landings can happen in jenkaas.
Description of the change
Ensure dev wheels are available in the dependencies branch so landings can happen in jenkaas.
Otto Co-Pilot (otto-copilot) wrote : | # |
The merge was fine but running tests failed.
Output of .pmr-merge-hook:
Database URL set to 'postgresql:
git clone https:/
New python executable in /tmp/tmpu5mzge/
Installing setuptools, pip...done.
Ignoring indexes: https:/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Installing collected packages: blinker, flask, gunicorn, lazr.postgresql, psycopg2, pygpgme, python-logstash, raven, sqlalchemy, statsd, itsdangerous, Werkzeug, Jinja2, contextlib2, MarkupSafe
Compiling /tmp/tmpu5mzge/
File "/tmp/tmpu5mzge
yield from self.wsgi.close()
^
SyntaxError: invalid syntax
Successfully installed blinker flask gunicorn lazr.postgresql psycopg2 pygpgme python-logstash raven sqlalchemy statsd itsdangerous Werkzeug Jinja2 contextlib2 MarkupSafe
Cleaning up...
Ignoring indexes: https:/
Downloading/
Running setup.py (path:/
warning: no previously-included files found matching 'ci/appveyor.token'
no previously-included directories found matching 'doc/_build'
no previously-included directories found matching 'tests/
no previously-included directories found matching 'tests/eggsrc/dist'
no previously-included directories found matching 'tests/
warning: no previously-included files matching '*.py[co]' found anywhere in distribution
Downloading/
Downloading/
Downloading/
Downloading/
Otto Co-Pilot (otto-copilot) wrote : | # |
The merge was fine but running tests failed.
Output of .pmr-merge-hook:
Database URL set to 'postgresql:
git clone https:/
New python executable in /tmp/tmpF8KIv4/
Installing setuptools, pip...done.
Ignoring indexes: https:/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Installing collected packages: blinker, flask, gunicorn, lazr.postgresql, psycopg2, pygpgme, python-logstash, raven, sqlalchemy, statsd, itsdangerous, Werkzeug, Jinja2, contextlib2, MarkupSafe
Compiling /tmp/tmpF8KIv4/
File "/tmp/tmpF8KIv4
yield from self.wsgi.close()
^
SyntaxError: invalid syntax
Successfully installed blinker flask gunicorn lazr.postgresql psycopg2 pygpgme python-logstash raven sqlalchemy statsd itsdangerous Werkzeug Jinja2 contextlib2 MarkupSafe
Cleaning up...
Ignoring indexes: https:/
Downloading/
Running setup.py (path:/
warning: no previously-included files found matching 'ci/appveyor.token'
no previously-included directories found matching 'doc/_build'
no previously-included directories found matching 'tests/
no previously-included directories found matching 'tests/eggsrc/dist'
no previously-included directories found matching 'tests/
warning: no previously-included files matching '*.py[co]' found anywhere in distribution
Downloading/
Downloading/
Downloading/
Downloading/
Otto Co-Pilot (otto-copilot) wrote : | # |
The merge was fine but running tests failed.
Output of .pmr-merge-hook:
Database URL set to 'postgresql:
git clone https:/
New python executable in /tmp/tmpgjv_
Installing setuptools, pip...done.
Ignoring indexes: https:/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Installing collected packages: blinker, flask, gunicorn, lazr.postgresql, psycopg2, pygpgme, python-logstash, raven, sqlalchemy, statsd, itsdangerous, Werkzeug, Jinja2, contextlib2, MarkupSafe
Compiling /tmp/tmpgjv_
File "/tmp/tmpgjv_
yield from self.wsgi.close()
^
SyntaxError: invalid syntax
Successfully installed blinker flask gunicorn lazr.postgresql psycopg2 pygpgme python-logstash raven sqlalchemy statsd itsdangerous Werkzeug Jinja2 contextlib2 MarkupSafe
Cleaning up...
Ignoring indexes: https:/
Downloading/
Running setup.py (path:/
warning: no previously-included files found matching 'ci/appveyor.token'
no previously-included directories found matching 'doc/_build'
no previously-included directories found matching 'tests/
no previously-included directories found matching 'tests/eggsrc/dist'
no previously-included directories found matching 'tests/
warning: no previously-included files matching '*.py[co]' found anywhere in distribution
Downloading/
Downloading/
Downloading/
Downloading/
Otto Co-Pilot (otto-copilot) wrote : | # |
The merge was fine but running tests failed.
Output of .pmr-merge-hook:
Database URL set to 'postgresql:
git clone https:/
New python executable in /tmp/tmpBOGY5S/
Installing setuptools, pip...done.
Ignoring indexes: https:/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Installing collected packages: blinker, flask, gunicorn, lazr.postgresql, psycopg2, pygpgme, python-logstash, raven, sqlalchemy, statsd, itsdangerous, Werkzeug, Jinja2, contextlib2, MarkupSafe
Compiling /tmp/tmpBOGY5S/
File "/tmp/tmpBOGY5S
yield from self.wsgi.close()
^
SyntaxError: invalid syntax
Successfully installed blinker flask gunicorn lazr.postgresql psycopg2 pygpgme python-logstash raven sqlalchemy statsd itsdangerous Werkzeug Jinja2 contextlib2 MarkupSafe
Cleaning up...
Ignoring indexes: https:/
Downloading/
Running setup.py (path:/
warning: no previously-included files found matching 'ci/appveyor.token'
no previously-included directories found matching 'doc/_build'
no previously-included directories found matching 'tests/
no previously-included directories found matching 'tests/eggsrc/dist'
no previously-included directories found matching 'tests/
warning: no previously-included files matching '*.py[co]' found anywhere in distribution
Downloading/
Downloading/
Downloading/
Downloading/
Vincent Ladeuil (vila) wrote : | # |
FAIL: test_verify_
gpgservice.
-------
_StringException: Traceback (most recent call last):
File "gpgservice/
resp.
File "/tmp/tmpBOGY5S
self.
File "/tmp/tmpBOGY5S
raise mismatch_error
testtools.
"status": "Error: Could not find GPG public key."
}
=======
FAIL: test_verifying_
gpgservice.
-------
_StringException: Traceback (most recent call last):
File "gpgservice/
self.
File "/tmp/tmpBOGY5S
self.
File "/tmp/tmpBOGY5S
raise mismatch_error
testtools.
=======
FAIL: test_verifying_
gpgservice.
-------
_StringException: Traceback (most recent call last):
File "gpgservice/
self.
File "/tmp/tmpBOGY5S
self.
File "/tmp/tmpBOGY5S
raise mismatch_error
testtools.
So the best I can come up with is that those 3 tests use need_keyserver=True and expect a 200 return code but got a 400.
The one I instrumented, additionally complaining that "Error: Could not find GPG public key.".
Any hints ?
I first mis-read 'need_keyserver' as implying keyserver.
The only way I can reproduce something vaguely related locally is by removing 'need_keyserver
Unmerged commits
- 43b0f95... by Vincent Ladeuil
-
Add some debug to diagnose the failure on jenkaas.
- 85fb4c6... by Vincent Ladeuil
-
All wheels should be available from the dependencies branch as pypi is not reachable when landing with jenkaas.
- 291150e... by Vincent Ladeuil
-
No changes
Preview Diff
1 | diff --git a/Makefile b/Makefile |
2 | index 639e654..66786d2 100644 |
3 | --- a/Makefile |
4 | +++ b/Makefile |
5 | @@ -36,7 +36,7 @@ update-dependencies: |
6 | cd $(DEPENDENCY_DIR) && git pull $(DEPENDENCY_REPO) |
7 | |
8 | $(ENV)/dev: $(ENV) |
9 | - @${PIP} install -f $(DEPENDENCY_DIR) -r requirements-dev.txt |
10 | + @${PIP} install -f $(DEPENDENCY_DIR) --no-index -r requirements-dev.txt |
11 | @touch $@ |
12 | |
13 | bootstrap: $(ENV)/dev |
14 | diff --git a/gpgservice/tests/test_webapp.py b/gpgservice/tests/test_webapp.py |
15 | index 7f535b4..a1207c6 100644 |
16 | --- a/gpgservice/tests/test_webapp.py |
17 | +++ b/gpgservice/tests/test_webapp.py |
18 | @@ -762,7 +762,9 @@ class VerifyDocumentTests(TestCase): |
19 | Neither has this part! |
20 | ''') |
21 | resp = fixture.post_to_verify(document) |
22 | - self.assertEqual(200, resp.status_code) |
23 | + self.assertEqual(200, resp.status_code, |
24 | + 'Got {} instead of 200 with data: {}'.format( |
25 | + resp.status_code, resp.data)) |
26 | self.assertEqual("This is a test document.\n", resp.data) |
27 | self.assertEqual("447DBF38C4F9C4ED752246B77D88913717B05A8F", |
28 | resp.headers['X-GPG-Verified-Fingerprint']) |
The merge was fine but running tests failed.
Output of .pmr-merge-hook:
Database URL set to 'postgresql: //postgres@ /gpgservice_ db?host= %(ROOT) s/dev-db/ localhost' /git.launchpad. net/~ubuntuone- hackers/ gpgservice/ +git/dependenci es /tmp/tmpYnkEKD/ tmp/dependencie s env/bin/ python /pypi.python. org/simple/ unpacking blinker==1.4 (from -r requirements.txt (line 1)) unpacking flask==0.10.1 (from -r requirements.txt (line 2)) unpacking gunicorn==19.4.5 (from -r requirements.txt (line 3)) unpacking lazr.postgresql ==0.0.2. post23 (from -r requirements.txt (line 4)) unpacking psycopg2==2.6.1 (from -r requirements.txt (line 5)) unpacking pygpgme==0.3 (from -r requirements.txt (line 6)) unpacking python- logstash= =0.4.5 (from -r requirements.txt (line 7)) unpacking raven==5.20.0 (from -r requirements.txt (line 8)) unpacking sqlalchemy==1.0.11 (from -r requirements.txt (line 9)) unpacking statsd==3.2.1 (from -r requirements.txt (line 10)) unpacking itsdangerous>=0.21 (from flask==0.10.1->-r requirements.txt (line 2)) unpacking Werkzeug>=0.7 (from flask==0.10.1->-r requirements.txt (line 2)) unpacking Jinja2>=2.4 (from flask==0.10.1->-r requirements.txt (line 2)) unpacking contextlib2 (from raven==5.20.0->-r requirements.txt (line 8)) unpacking MarkupSafe (from Jinja2> =2.4->flask= =0.10.1- >-r requirements.txt (line 2)) env/build/ gunicorn/ gunicorn/ workers/ _gaiohttp. py ... /env/build/ gunicorn/ gunicorn/ workers/ _gaiohttp. py", line 78
git clone https:/
New python executable in /tmp/tmpYnkEKD/
Installing setuptools, pip...done.
Ignoring indexes: https:/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Downloading/
Installing collected packages: blinker, flask, gunicorn, lazr.postgresql, psycopg2, pygpgme, python-logstash, raven, sqlalchemy, statsd, itsdangerous, Werkzeug, Jinja2, contextlib2, MarkupSafe
Compiling /tmp/tmpYnkEKD/
File "/tmp/tmpYnkEKD
yield from self.wsgi.close()
^
SyntaxError: invalid syntax
Successfully installed blinker flask gunicorn lazr.postgresql psycopg2 pygpgme python-logstash raven sqlalchemy statsd itsdangerous Werkzeug Jinja2 contextlib2 MarkupSafe unpacking coverage (from -r requirements- dev.txt (line 1)) /pypi.python. org/simple/ dev.txt (line 1)) dev.txt (line 1)) .pip/pip. log
Cleaning up...
Downloading/
Cannot fetch index base URL https:/
Could not find any downloads that satisfy the requirement coverage (from -r requirements-
Cleaning up...
No distributions at all found for coverage (from -r requirements-
Storing debug log for failure in /home/ubuntu/