Merge lp:~vila/conn-check/fix-deps into lp:conn-check

Proposed by Vincent Ladeuil on 2017-02-08
Status: Merged
Approved by: Otto Co-Pilot on 2017-02-10
Approved revision: 136
Merged at revision: 136
Proposed branch: lp:~vila/conn-check/fix-deps
Merge into: lp:conn-check
Diff against target: 15 lines (+3/-0)
1 file modified
requirements.txt (+3/-0)
To merge this branch: bzr merge lp:~vila/conn-check/fix-deps
Reviewer Review Type Date Requested Status
Guillermo Gonzalez 2017-02-08 Approve on 2017-02-10
Review via email: mp+316691@code.launchpad.net

Commit message

Add missing dependencies.

Description of the change

I noticed from https://jenkins.ols.canonical.com/online-services/job/conn-check-landing-tests/8/console that conn-check didn't pass its own landing tests for trunk anymore.

Reproducing locally, I came up with that fix.

I'm not sure that's the right way as this adds more unpinned dependencies, but it works.

I don't fully understand the dependencies graph here either :-/

To post a comment you must log in.
Guillermo Gonzalez (verterok) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'requirements.txt'
2--- requirements.txt 2016-08-18 13:24:07 +0000
3+++ requirements.txt 2017-02-08 12:29:18 +0000
4@@ -1,8 +1,11 @@
5+appdirs
6 characteristic >= 14.0
7 cryptography >= 0.5
8 ndg-httpsclient
9+packaging
10 pyasn1
11 pyOpenSSL
12+pyparsing
13 service-identity
14 requests
15 Twisted<15

Subscribers

People subscribed via source and target branches