Merge lp:~vila/charms/precise/ubuntu-ci-services-itself/upstart into lp:~canonical-ci-engineering/charms/precise/ubuntu-ci-services-itself/upstart

Proposed by Vincent Ladeuil on 2014-03-21
Status: Merged
Approved by: Vincent Ladeuil on 2014-03-25
Approved revision: 7
Merged at revision: 7
Proposed branch: lp:~vila/charms/precise/ubuntu-ci-services-itself/upstart
Merge into: lp:~canonical-ci-engineering/charms/precise/ubuntu-ci-services-itself/upstart
Diff against target: 10 lines (+1/-0)
1 file modified
hooks/hooks.py (+1/-0)
To merge this branch: bzr merge lp:~vila/charms/precise/ubuntu-ci-services-itself/upstart
Reviewer Review Type Date Requested Status
Paul Larson 2014-03-21 Approve on 2014-03-24
Review via email: mp+212263@code.launchpad.net

Commit message

Activate the respawn flag.

Description of the change

http://upstart.ubuntu.com/wiki/Stanzas#respawn is explicit:

Description: This configures the respawn limits, which only apply if the respawn flag is set.

To post a comment you must log in.
Paul Larson (pwlars) wrote :

I thought we had fixed this long ago. Maybe it got dropped somewhere or was specific to some other upstart job.

review: Approve
Vincent Ladeuil (vila) wrote :

> I thought we had fixed this long ago. Maybe it got dropped somewhere or was
> specific to some other upstart job.

Yeah, the flag is there in ubuntu-ci-services-itself for the components that generate similar jobs. I changed the comments slightly to outline that in https://code.launchpad.net/~vila/ubuntu-ci-services-itself/1285386-ppa-cleaner-failed-to-start/+merge/212264

I'm also wondering if we should revisit the respawn limits and/or catch more exceptions explicitly in the jobs themselves.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/hooks.py'
2--- hooks/hooks.py 2014-01-15 20:11:57 +0000
3+++ hooks/hooks.py 2014-03-21 23:57:57 +0000
4@@ -40,6 +40,7 @@
5 stop on {stop_on}
6
7 # If the process quits unexpectadly trigger a respawn
8+ respawn
9 # give it 15 chances with a 5 second delay in between retries
10 respawn limit 15 5
11

Subscribers

People subscribed via source and target branches