lp:~vila/charms/precise/tarmac/fix-template-expansion

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~canonical-ci-engineering/charms/precise/tarmac/trunk at revision 59

Evan (community): Approve on 2014-11-14

Diff: 71 lines (+27/-2)

2 files modified

hooks/hooks.py (+4/-2)
unit_tests/test_hooks.py (+23/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

64. By Vincent Ladeuil on 2014-11-14

Merge further fixes from the cleanup branch

63. By Vincent Ladeuil on 2014-11-14

Make sure we always keep the final newline in all templates.

62. By Vincent Ladeuil on 2014-11-14

Add failing tests for the missing newline in the expanded template. Note that this doesn't fail for tarmac.conf because there is a template loop there that leaves one empty line before and one empty line after each section.

61. By Vincent Ladeuil on 2014-11-14

Add ssh_dir to the common mocks or adding a new ssh test will target ~/.ssh and confuse testers ;)

60. By Vincent Ladeuil on 2014-11-14

Cleanup removing '%' usage in faour of .format(). Cleanup 'tmpl_data' in favour of 'expanded' as we care about the template expansion result.

59. By Vincent Ladeuil on 2014-11-14

Fix existing test failure: split() is better than split(' ').

58. By Vincent Ladeuil on 2014-11-10

Remove unused imports.

57. By Vincent Ladeuil on 2014-11-10

Don't hash hosts for ssh or we lose track of which ones are there.

56. By Evan on 2014-07-03

Cron is unhappy if it doesn't have an empty line at the end of the file.

55. By Evan on 2014-07-01

This greatly confuses juju.