Merge lp:~vila/bzr/utextwrap-sphinx into lp:bzr

Proposed by Vincent Ladeuil
Status: Merged
Approved by: Vincent Ladeuil
Approved revision: no longer in the source branch.
Merged at revision: 6523
Proposed branch: lp:~vila/bzr/utextwrap-sphinx
Merge into: lp:bzr
Diff against target: 38 lines (+3/-14)
2 files modified
bzrlib/tests/test_utextwrap.py (+0/-10)
doc/en/release-notes/bzr-2.6.txt (+3/-4)
To merge this branch: bzr merge lp:~vila/bzr/utextwrap-sphinx
Reviewer Review Type Date Requested Status
Jelmer Vernooij (community) Approve
Review via email: mp+102289@code.launchpad.net

Commit message

Avoid test sphinx-related failures now that we don't have direct sphinx anymore.

Description of the change

This fixes test failures caused by a forgotten reference to
``test.features.sphinx``.

The sphinx availability test is not needed anymore (we've removed the
texinfo sphinx builder from our sources).

This caused failures on freebsd8 on babune only for reasons too long to
explain here ;)

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) :
review: Approve
Revision history for this message
Vincent Ladeuil (vila) wrote :

sent to pqm by email

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bzrlib/tests/test_utextwrap.py'
2--- bzrlib/tests/test_utextwrap.py 2011-05-28 06:44:01 +0000
3+++ bzrlib/tests/test_utextwrap.py 2012-04-17 12:36:22 +0000
4@@ -171,16 +171,6 @@
5
6
7 def setup_both(testcase, base_class, reused_class):
8-
9- if (features.sphinx.available()):
10- # Until https://bitbucket.org/birkenfeld/sphinx/issue/706 is fixed,
11- # we can't run these tests when sphinx <= 1.0.1 as it breaks
12- # textwrap.TextWrapper.wordsep_re
13- version = tuple(map(int,
14- features.sphinx.module.__version__.split('.')))
15- if version <= (1, 0, 7):
16- raise tests.TestSkipped(
17- 'sphinx textwrap monkeypatch breaks utextwrap')
18 super(base_class, testcase).setUp()
19 override_textwrap_symbols(testcase)
20 reused_class.setUp(testcase)
21
22=== modified file 'doc/en/release-notes/bzr-2.6.txt'
23--- doc/en/release-notes/bzr-2.6.txt 2012-04-16 11:08:11 +0000
24+++ doc/en/release-notes/bzr-2.6.txt 2012-04-17 12:36:22 +0000
25@@ -67,10 +67,9 @@
26 Testing
27 *******
28
29-.. Fixes and changes that are only relevant to bzr's test framework and
30- suite. This can include new facilities for writing tests, fixes to
31- spurious test failures and changes to the way things should be tested.
32-
33+* Fix test failures by removing a remaining reference to ``features.sphinx``
34+ which isn't needed anymore since we don't test the texinfo sphinx builder
35+ anymore either. (Vincent Ladeuil)
36
37 bzr 2.6b1
38 #########