Merge lp:~vila/bzr/test-server-races into lp:bzr
Status: | Merged |
---|---|
Approved by: | Martin Packman |
Approved revision: | no longer in the source branch. |
Merged at revision: | 6337 |
Proposed branch: | lp:~vila/bzr/test-server-races |
Merge into: | lp:bzr |
Diff against target: |
131 lines (+27/-26) 2 files modified
bzrlib/tests/test_server.py (+12/-8) bzrlib/tests/test_test_server.py (+15/-18) |
To merge this branch: | bzr merge lp:~vila/bzr/test-server-races |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Packman (community) | Approve | ||
Review via email: mp+84096@code.launchpad.net |
Commit message
Properly synchronize connection thread start with test server main thread.
Description of the change
This is a followup to the fix for bug #869366 that was sitting on disk for
no good reasons.
It removes one race in the test server when a connection thread is started.
Under rare circumstances (described in bug #869366) an exception in the
connection thread was raised in the server thread too early leading to
semi-hackish tests.
The connection thread will now wait for the server thread to resume its
normal course before processing the conection.
I see no reason why this should address the other issues we currently have
but I may be wrong.
On the other hand, this is clearly better and remove one source of possible
confusion.
Okay, this all makes sense to me given the earlier merge proposal context.