Code review comment for lp:~vila/bzr/split-diff-tests
Revision history for this message
| Vincent Ladeuil (vila) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
> Thanks, Vincent, for the improved granularity and specificity of the tests.
> The use of scenarios is powerful!
>
> Regarding '--forward-ed' not part of diff v3.3:
> How does diff v3.3 treat a command line which includes the removed option
> '--forward-ed'? Does it quietly ignore it or abort with an error code?
Good point ! The option appears to be still supported even if it's not mentioned in the man page nor the online help anymore.
>
> In either case, since the user is explicitly specifying the option, it seems
> benign to continue to regard it as a valid format option--at least as long as
> we are still supporting diff v3.2.
Agreed, I've removed the comment.
And for the future, I think you're right, once the option is not supported by diff anymore, our users will soon enough discover that the issue is with diff itself.