Merge lp:~vila/bzr/selftest-start-load into lp:~bzr/bzr/trunk-old

[Vincent Ladeuil]

[Vincent Ladeuil (vila)]

1) try: bzr selftest -s xxx --load failures
2) Cry
3) Apply proposed fix
4) ...
5) Rejoice !

[Vincent Ladeuil (vila)]

Given that https://code.edge.launchpad.net/~bzr/bzr/trunk says:

Last mirrored: 23 minutes ago
Next mirror: in 5 hours

I guess I'll have to resubmit to present a proper diff :-/

[Martin Pool (mbp)]

Please, when the diff is so big, put on a more explicit cover letter saying what you changed...

I guess you mean --load-list?

[Martin Pool (mbp)]

> Please, when the diff is so big, put on a more explicit cover letter saying
> what you changed...
>
> I guess you mean --load-list?

OK, I see the real diff is a bit more reasonable.

review: Approve

[Vincent Ladeuil (vila)]

>>>>> "martin" == Martin Pool writes:

    martin> Review: Approve

Thanks.

    >> Please, when the diff is so big, put on a more explicit
    >> cover letter saying what you changed...

Talk about the lp bug ruining my joke...

The change had landed on bazaar-vcs.org when I did the merge
request, but apparently it hasn't been mirrored which may partly
explain the problem.

    >>
    >> I guess you mean --load-list?

    martin> OK, I see the real diff is a bit more reasonable.

Yes, the "real" diff was intended to be "obvious" :-/

=== modified file 'bzrlib/tests/__init__.py'
--- bzrlib/tests/__init__.py	2009-06-29 15:25:08 +0000
+++ bzrlib/tests/__init__.py	2009-07-01 22:35:21 +0000
@@ -3508,6 +3508,8 @@
 
     loader = TestUtil.TestLoader()
 
+    if keep_only is not None:
+        id_filter = TestIdList(keep_only)
     if starting_with:
         starting_with = [test_prefix_alias_registry.resolve_alias(start)
                          for start in starting_with]
@@ -3526,7 +3528,6 @@
         loader = TestUtil.FilteredByModuleTestLoader(interesting_module)
 
     elif keep_only is not None:
-        id_filter = TestIdList(keep_only)
         loader = TestUtil.FilteredByModuleTestLoader(id_filter.refers_to)
         def interesting_module(name):
             return id_filter.refers_to(name)

=== modified file 'bzrlib/tests/test_selftest.py'
--- bzrlib/tests/test_selftest.py	2009-07-01 14:21:56 +0000
+++ bzrlib/tests/test_selftest.py	2009-07-01 22:35:21 +0000
@@ -2170,24 +2170,6 @@
         self.assertTrue(id_list.refers_to('mod.class'))
         self.assertTrue(id_list.refers_to('mod.class.meth'))
 
-    def test_test_suite(self):
-        # This test is slow, so we do a single test with one test in each
-        # category
-        test_list = [
-            # testmod_names
-            'bzrlib.tests.blackbox.test_branch.TestBranch.test_branch',
-            'bzrlib.tests.test_selftest.TestTestIdList.test_test_suite',
-            # transport implementations
-            'bzrlib.tests.test_transport_implementations.TransportTests'
-            '.test_abspath(LocalURLServer)',
-            # modules_to_doctest
-            'bzrlib.timestamp.format_highres_date',
-            # plugins can't be tested that way since selftest may be run with
-            # --no-plugins
-            ]
-        suite = tests.test_suite(test_list)
-        self.assertEquals(test_list, _test_ids(suite))
-
     def test_test_suite_matches_id_list_with_unknown(self):
         loader = TestUtil.TestLoader()
         suite = loader.loadTestsFromModuleName('bzrlib.tests.test_sampler')
@@ -2213,6 +2195,34 @@
                           duplicates)
 
 
+class TestTestSuite(tests.TestCase):
+
+    def test_test_suite(self):
+        # This test is slow, so we do a single test with one test in each
+        # category
+        test_list = [
+            # testmod_names
+            'bzrlib.tests.blackbox.test_branch.TestBranch.test_branch',
+            'bzrlib.tests.test_selftest.TestTestSuite.test_test_suite',
+            # transport implementations
+            'bzrlib.tests.test_transport_implementations.TransportTests'
+            '.test_abspath(LocalURLServer)',
+            # modules_to_doctest
+            'bzrlib.timestamp.format_highres_date',
+            # plugins can't be tested that way since selftest may be run with
+            # --no-plugins
+            ]
+        suite = tests.test_suite(test_list)
+        self.assertEquals(test_list, _test_ids(suite))
+
+    def test_test_suite_list_and_start(self):
+        test_list = ['bzrlib.tests.test_selftest.TestTestSuite.test_test_suite']
+        suite = tests.test_suite(test_list,
+                                 ['bzrlib.tests.test_selftest.TestTestSuite'])
+        # test_test_suite_list_and_start is not included 
+        self.assertEquals(test_list, _test_ids(suite))
+
+
 class TestLoadTestIdList(tests.TestCaseInTempDir):
 
     def _create_test_list_file(self, file_name, content):