Code review comment for lp:~vila/bzr/more-concurrency

Given that this isn't performance critical code, would it be more reasonable to just have a fall-through (which is what we used to have) rather than forcibly require the platform to match?

I'm just thinking that some platform strings may not be recognized. This, of course, assumes that if any attempt *works* it gives the right answer.

Also, as for NUMBER_OF_CORES, on my core2 duo I see NUMBER_OF_PROCESSORS = 2, even though it is a single physical processor w/ 2 cores. So I'm not sure that is true.

Anyway, you don't have to change anything to land it, I'm just not sure of the specific benefit of having sys.platform checks.