Merge lp:~vila/bzr/expand-default-true into lp:bzr
Status: | Merged |
---|---|
Approved by: | Martin Packman |
Approved revision: | no longer in the source branch. |
Merged at revision: | 6488 |
Proposed branch: | lp:~vila/bzr/expand-default-true |
Merge into: | lp:bzr |
Diff against target: |
174 lines (+8/-89) 4 files modified
bzrlib/config.py (+3/-28) bzrlib/tests/__init__.py (+0/-4) bzrlib/tests/test_config.py (+0/-57) doc/en/release-notes/bzr-2.6.txt (+5/-0) |
To merge this branch: | bzr merge lp:~vila/bzr/expand-default-true |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Packman (community) | Approve | ||
Review via email: mp+93367@code.launchpad.net |
Commit message
This turns config option expansion on by default.
Description of the change
This turns config option expansion on by default.
This has been introduced as an opt-in feature long ago (well before we
started migrating options) and I've opt-in myself since day one.
There has been no negative feedback on this so I'd like to get rid of the
option all together since I've since never encountered a valid use case
where a refernce ({option}) needs to not be expanded.
It's trivially true for most of the options used inside brzlib *except* for
templates which obviously want to delay the option expansion.
Cleaning up the code revealed a single case where expand=False was required
(mergetools) and this was indeed a template.
I'm targetting trunk to ensure this doesn't break use cases I'm not aware of, but we may want to backport to 2.5 if nothing bad happens.
Seems reasonable for 2.6 where any remaining issues should get shaken out. The qbzr external merge should be sharing the same config now, I'm not sure what other plugins might do their own templating.