Code review comment for lp:~vila/bzr/956860-doc-generate

Revision history for this message
Vincent Ladeuil (vila) wrote :

> Hu, a script that uses bzrlib.initialize() and
> commands.install_bzr_command_hooks() but still needs more dancing to actually
> work.
>

<shudder>, yes :-/ And I did use bzrlib.initialize() *just* to avoid such issues here...(That is, the last time I touched generate_docs).

Poking jelmer for further advice as I think it's a fallout from his work on lazy loading (not throwing stones, really, but there may be a way to avoid this particular fallout by still loading something wt/branch/repo ?)

> We end up doing a lot using the bzrlib tree just when calling setup.py which
> dirties the state rather.

I don't follow, generate_docs is not related to setup.py, what do you mean ?

« Back to merge proposal