Code review comment for lp:~vila/bzr/786980-url-aliases

Vincent Ladeuil (vila) wrote :

> # bond_location" typo
> "fron" typo

> the release note doesn't describe the bug very well, it should mention that it fixes the readonlyerror

Bah, thanks. Fixed.

> Suggestions to make the test more foolproof, add instances other than trailing slashes in URL such as including + or ~ characters.

I limit myself to the reproducing test while targetting 2.3, for trunk I think we should even test that total garbage entries in the config file is handled cleanly. Can I get this proposal accepted and address this issue in a followup ?

> Add changes to the branch before the update.

That seems unrelated to the issue, what do you have in mind ?

review: Needs Information

« Back to merge proposal